From 2de769420eb46d3855969f796f38ce0235e9a41e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Piotr=20Jamr=C3=B3z?= <pm.jamroz@gmail.com>
Date: Mon, 18 Oct 2021 10:40:43 +0200
Subject: [PATCH] Chore: Reduce strict error in DataSourceHttpSettings.onChange
 callback (#40497)

* Reduce strict TS errors

* Update ERROR_COUNT_LIMIT after merging from main

* Update number of errors
---
 .../grafana-ui/src/components/DataSourceSettings/types.ts   | 6 +++---
 scripts/ci-check-strict.sh                                  | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/packages/grafana-ui/src/components/DataSourceSettings/types.ts b/packages/grafana-ui/src/components/DataSourceSettings/types.ts
index 8d8115a6c17..f298651b3e7 100644
--- a/packages/grafana-ui/src/components/DataSourceSettings/types.ts
+++ b/packages/grafana-ui/src/components/DataSourceSettings/types.ts
@@ -6,11 +6,11 @@ export interface AzureAuthSettings {
   azureSettingsUI?: React.ComponentType<HttpSettingsBaseProps>;
 }
 
-export interface HttpSettingsBaseProps {
+export interface HttpSettingsBaseProps<JSONData = any, SecureJSONData = any> {
   /** The configuration object of the data source */
-  dataSourceConfig: DataSourceSettings<any, any>;
+  dataSourceConfig: DataSourceSettings<JSONData, SecureJSONData>;
   /** Callback for handling changes to the configuration object */
-  onChange: (config: DataSourceSettings) => void;
+  onChange: (config: DataSourceSettings<JSONData, SecureJSONData>) => void;
   /** Show the Forward OAuth identity option */
   showForwardOAuthIdentityOption?: boolean;
 }
diff --git a/scripts/ci-check-strict.sh b/scripts/ci-check-strict.sh
index d1a92df923d..4203fefd658 100755
--- a/scripts/ci-check-strict.sh
+++ b/scripts/ci-check-strict.sh
@@ -3,7 +3,7 @@ set -e
 
 echo -e "Collecting code stats (typescript errors & more)"
 
-ERROR_COUNT_LIMIT=17
+ERROR_COUNT_LIMIT=13
 ERROR_COUNT="$(./node_modules/.bin/tsc --project tsconfig.json --noEmit --strict true | grep -oP 'Found \K(\d+)')"
 
 if [ "$ERROR_COUNT" -gt $ERROR_COUNT_LIMIT ]; then