From 3245227016e8f60a9171f37791a4d6e4edaa8c82 Mon Sep 17 00:00:00 2001
From: Leonard Gram <leo@xlson.com>
Date: Wed, 17 Oct 2018 15:58:52 +0200
Subject: [PATCH] permissions: cleanup.

---
 pkg/api/datasources.go   | 18 +-----------------
 pkg/models/datasource.go | 10 ++--------
 2 files changed, 3 insertions(+), 25 deletions(-)

diff --git a/pkg/api/datasources.go b/pkg/api/datasources.go
index e9eb78fbe13..e7614614076 100644
--- a/pkg/api/datasources.go
+++ b/pkg/api/datasources.go
@@ -17,24 +17,8 @@ func GetDataSources(c *m.ReqContext) Response {
 		return Error(500, "Failed to query datasources", err)
 	}
 
-	dsFilterQuery := m.DatasourcesPermissionFilterQuery{
-		User:        c.SignedInUser,
-		Datasources: query.Result,
-	}
-
-	var datasources []*m.DataSource
-	if err := bus.Dispatch(&dsFilterQuery); err != nil {
-		if err != bus.ErrHandlerNotFound {
-			return Error(500, "Could not get datasources", err)
-		}
-
-		datasources = query.Result
-	} else {
-		datasources = dsFilterQuery.Result
-	}
-
 	result := make(dtos.DataSourceList, 0)
-	for _, ds := range datasources {
+	for _, ds := range query.Result {
 		dsItem := dtos.DataSourceListItemDTO{
 			OrgId:     ds.OrgId,
 			Id:        ds.Id,
diff --git a/pkg/models/datasource.go b/pkg/models/datasource.go
index 488fb2fe1fa..b71d17ec0d1 100644
--- a/pkg/models/datasource.go
+++ b/pkg/models/datasource.go
@@ -195,8 +195,8 @@ type GetDataSourceByNameQuery struct {
 type DsPermissionType int
 
 const (
-	DsPermissionQuery DsPermissionType = 1 << iota
-	DsPermissionNoAccess
+	DsPermissionNoAccess DsPermissionType = iota
+	DsPermissionQuery
 )
 
 func (p DsPermissionType) String() string {
@@ -207,12 +207,6 @@ func (p DsPermissionType) String() string {
 	return names[int(p)]
 }
 
-type HasRequiredDataSourcePermissionQuery struct {
-	Id                 int64
-	User               *SignedInUser
-	RequiredPermission DsPermissionType
-}
-
 type GetDataSourcePermissionsForUserQuery struct {
 	User   *SignedInUser
 	Result map[int64]DsPermissionType