From 324b33146a7c785f38340e1e36a0a75f582b0111 Mon Sep 17 00:00:00 2001 From: Levente Balogh Date: Thu, 13 Jul 2023 11:31:02 +0200 Subject: [PATCH] Datasources: Pass down the edit-form errors (#69830) feat: pass the error to the event handler --- .../app/features/datasources/components/EditDataSource.tsx | 6 +++--- public/app/features/datasources/tracking.ts | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/public/app/features/datasources/components/EditDataSource.tsx b/public/app/features/datasources/components/EditDataSource.tsx index 055f8ce3e1d..a837c1ec030 100644 --- a/public/app/features/datasources/components/EditDataSource.tsx +++ b/public/app/features/datasources/components/EditDataSource.tsx @@ -130,10 +130,10 @@ export function EditDataSourceView({ try { await onUpdate({ ...dataSource }); - trackDsConfigUpdated('success'); + trackDsConfigUpdated({ item: 'success' }); appEvents.publish(new DataSourceUpdatedSuccessfully()); - } catch (err) { - trackDsConfigUpdated('fail'); + } catch (error) { + trackDsConfigUpdated({ item: 'fail', error }); return; } diff --git a/public/app/features/datasources/tracking.ts b/public/app/features/datasources/tracking.ts index a244f090dd8..c0b39029aa2 100644 --- a/public/app/features/datasources/tracking.ts +++ b/public/app/features/datasources/tracking.ts @@ -83,6 +83,6 @@ export const trackDsConfigClicked = (item: string) => { reportInteraction('connections_datasources_settings_clicked', { item }); }; -export const trackDsConfigUpdated = (item: string) => { - reportInteraction('connections_datasources_ds_configured', { item }); +export const trackDsConfigUpdated = (props: { item: string; error?: unknown }) => { + reportInteraction('connections_datasources_ds_configured', props); };