From 34299a1bd2d8cea74869d5d74cf0ba78786a47ab Mon Sep 17 00:00:00 2001
From: csyangchen <csyangchen@hotmail.com>
Date: Thu, 12 Dec 2019 00:01:01 +0800
Subject: [PATCH] Alerting: Fix panic in dingding notifier  (#20378)

dingding notifier fails to send alert messages containing JSON,
This change use map and json.Marshal to always produce valid
JSON body.

Fixes #9771
---
 pkg/services/alerting/notifiers/dingding.go   | 79 +++++++++----------
 .../alerting/notifiers/dingding_test.go       | 12 +++
 2 files changed, 50 insertions(+), 41 deletions(-)

diff --git a/pkg/services/alerting/notifiers/dingding.go b/pkg/services/alerting/notifiers/dingding.go
index fc8ce477ecb..54562a2eef5 100644
--- a/pkg/services/alerting/notifiers/dingding.go
+++ b/pkg/services/alerting/notifiers/dingding.go
@@ -1,12 +1,11 @@
 package notifiers
 
 import (
+	"encoding/json"
 	"fmt"
 	"net/url"
-	"strings"
 
 	"github.com/grafana/grafana/pkg/bus"
-	"github.com/grafana/grafana/pkg/components/simplejson"
 	"github.com/grafana/grafana/pkg/infra/log"
 	"github.com/grafana/grafana/pkg/models"
 	"github.com/grafana/grafana/pkg/services/alerting"
@@ -70,6 +69,26 @@ func (dd *DingDingNotifier) Notify(evalContext *alerting.EvalContext) error {
 		messageURL = ""
 	}
 
+	body, err := dd.genBody(evalContext, messageURL)
+	if err != nil {
+		return err
+	}
+
+	cmd := &models.SendWebhookSync{
+		Url:  dd.URL,
+		Body: string(body),
+	}
+
+	if err := bus.DispatchCtx(evalContext.Ctx, cmd); err != nil {
+		dd.log.Error("Failed to send DingDing", "error", err, "dingding", dd.Name)
+		return err
+	}
+
+	return nil
+}
+
+func (dd *DingDingNotifier) genBody(evalContext *alerting.EvalContext, messageURL string) ([]byte, error) {
+
 	q := url.Values{
 		"pc_slide": {"false"},
 		"url":      {messageURL},
@@ -92,54 +111,32 @@ func (dd *DingDingNotifier) Notify(evalContext *alerting.EvalContext) error {
 		message += fmt.Sprintf("\\n%2d. %s: %s", i+1, match.Metric, match.Value)
 	}
 
-	var bodyStr string
+	var bodyMsg map[string]interface{}
 	if dd.MsgType == "actionCard" {
 		// Embed the pic into the markdown directly because actionCard doesn't have a picUrl field
 		if picURL != "" {
 			message = "![](" + picURL + ")\\n\\n" + message
 		}
 
-		bodyStr = `{
+		bodyMsg = map[string]interface{}{
 			"msgtype": "actionCard",
-			"actionCard": {
-				"text": "` + strings.Replace(message, `"`, "'", -1) + `",
-				"title": "` + strings.Replace(title, `"`, "'", -1) + `",
+			"actionCard": map[string]string{
+				"text":        message,
+				"title":       title,
 				"singleTitle": "More",
-				"singleURL": "` + messageURL + `"
-			}
-		}`
+				"singleURL":   messageURL,
+			},
+		}
 	} else {
-		bodyStr = `{
+		bodyMsg = map[string]interface{}{
 			"msgtype": "link",
-			"link": {
-				"text": "` + message + `",
-				"title": "` + title + `",
-				"picUrl": "` + picURL + `",
-				"messageUrl": "` + messageURL + `"
-			}
-		}`
+			"link": map[string]string{
+				"text":       message,
+				"title":      title,
+				"picUrl":     picURL,
+				"messageUrl": messageURL,
+			},
+		}
 	}
-
-	bodyJSON, err := simplejson.NewJson([]byte(bodyStr))
-
-	if err != nil {
-		dd.log.Error("Failed to create Json data", "error", err, "dingding", dd.Name)
-	}
-
-	body, err := bodyJSON.MarshalJSON()
-	if err != nil {
-		return err
-	}
-
-	cmd := &models.SendWebhookSync{
-		Url:  dd.URL,
-		Body: string(body),
-	}
-
-	if err := bus.DispatchCtx(evalContext.Ctx, cmd); err != nil {
-		dd.log.Error("Failed to send DingDing", "error", err, "dingding", dd.Name)
-		return err
-	}
-
-	return nil
+	return json.Marshal(bodyMsg)
 }
diff --git a/pkg/services/alerting/notifiers/dingding_test.go b/pkg/services/alerting/notifiers/dingding_test.go
index 09101af2f8f..03b1a545e19 100644
--- a/pkg/services/alerting/notifiers/dingding_test.go
+++ b/pkg/services/alerting/notifiers/dingding_test.go
@@ -1,10 +1,12 @@
 package notifiers
 
 import (
+	"context"
 	"testing"
 
 	"github.com/grafana/grafana/pkg/components/simplejson"
 	"github.com/grafana/grafana/pkg/models"
+	"github.com/grafana/grafana/pkg/services/alerting"
 	. "github.com/smartystreets/goconvey/convey"
 )
 
@@ -41,6 +43,16 @@ func TestDingDingNotifier(t *testing.T) {
 			So(notifier.Name, ShouldEqual, "dingding_testing")
 			So(notifier.Type, ShouldEqual, "dingding")
 			So(notifier.URL, ShouldEqual, "https://www.google.com")
+
+			Convey("genBody should not panic", func() {
+				evalContext := alerting.NewEvalContext(context.Background(),
+					&alerting.Rule{
+						State:   models.AlertStateAlerting,
+						Message: `{host="localhost"}`,
+					})
+				_, err = notifier.genBody(evalContext, "")
+				So(err, ShouldBeNil)
+			})
 		})
 	})
 }