Alerting: Delete permanently deleted alert rules. (#102960)

* add alertingDeletePermanently ff

* add delete permanently button in Recently deleted page

* use ff to protect delete permanent button column

* update transations and prettier

* invalidate tag and update transalations keys

* add test

* prettier

* refactor test

* restore wrong change in deleteRulerRuleGroupHandler

* update test

* linter

* Alerting: Permanent delete rules code review (#103288)

* Update feature toggle name and description

* Rename mutation endpoint

* Fix typo and update text to be "permanently delete"

* Update feature toggle and test

* Move delete button into actions column

* generate ff

* address feedback

---------

Co-authored-by: Tom Ratcliffe <tom.ratcliffe@grafana.com>
This commit is contained in:
Sonia Aguilar
2025-04-03 14:18:25 +03:00
committed by GitHub
co-authored by Tom Ratcliffe
parent 50825a8299
commit 3450d243b9
16 changed files with 255 additions and 34 deletions
+10
View File
@@ -1838,6 +1838,16 @@ var (
FrontendOnly: true,
Owner: grafanaObservabilityLogsSquad,
},
{
Name: "alertingRulePermanentlyDelete",
Description: "Enables UI functionality to permanently delete alert rules",
FrontendOnly: true,
Stage: FeatureStageGeneralAvailability,
Owner: grafanaAlertingSquad,
HideFromAdminPage: true,
HideFromDocs: true,
Expression: "true", // enabled by default
},
{
Name: "alertingRuleRecoverDeleted",
Description: "Enables the UI functionality to recover and view deleted alert rules",
+1
View File
@@ -242,6 +242,7 @@ azureMonitorLogsBuilderEditor,preview,@grafana/partner-datasources,false,false,f
localeFormatPreference,experimental,@grafana/grafana-frontend-platform,false,false,false
unifiedStorageGrpcConnectionPool,experimental,@grafana/search-and-storage,false,false,false
extensionSidebar,experimental,@grafana/observability-logs,false,false,true
alertingRulePermanentlyDelete,GA,@grafana/alerting-squad,false,false,true
alertingRuleRecoverDeleted,GA,@grafana/alerting-squad,false,false,true
xrayApplicationSignals,experimental,@grafana/aws-datasources,false,false,true
multiTenantTempCredentials,experimental,@grafana/aws-datasources,false,false,false
1 Name Stage Owner requiresDevMode RequiresRestart FrontendOnly
242 localeFormatPreference experimental @grafana/grafana-frontend-platform false false false
243 unifiedStorageGrpcConnectionPool experimental @grafana/search-and-storage false false false
244 extensionSidebar experimental @grafana/observability-logs false false true
245 alertingRulePermanentlyDelete GA @grafana/alerting-squad false false true
246 alertingRuleRecoverDeleted GA @grafana/alerting-squad false false true
247 xrayApplicationSignals experimental @grafana/aws-datasources false false true
248 multiTenantTempCredentials experimental @grafana/aws-datasources false false false
+4
View File
@@ -979,6 +979,10 @@ const (
// Enables the extension sidebar
FlagExtensionSidebar = "extensionSidebar"
// FlagAlertingRulePermanentlyDelete
// Enables UI functionality to permanently delete alert rules
FlagAlertingRulePermanentlyDelete = "alertingRulePermanentlyDelete"
// FlagAlertingRuleRecoverDeleted
// Enables the UI functionality to recover and view deleted alert rules
FlagAlertingRuleRecoverDeleted = "alertingRuleRecoverDeleted"
+33
View File
@@ -249,6 +249,23 @@
"hideFromDocs": true
}
},
{
"metadata": {
"name": "alertingDeletePermanently",
"resourceVersion": "1742988550168",
"creationTimestamp": "2025-03-26T11:29:10Z",
"deletionTimestamp": "2025-04-02T14:29:49Z"
},
"spec": {
"description": "Enables the UI functionality to delete permanently alert rules",
"stage": "GA",
"codeowner": "@grafana/alerting-squad",
"frontend": true,
"hideFromAdminPage": true,
"hideFromDocs": true,
"expression": "true"
}
},
{
"metadata": {
"name": "alertingDisableSendAlertsExternal",
@@ -437,6 +454,22 @@
"expression": "false"
}
},
{
"metadata": {
"name": "alertingRulePermanentlyDelete",
"resourceVersion": "1743604189392",
"creationTimestamp": "2025-04-02T14:29:49Z"
},
"spec": {
"description": "Enables UI functionality to permanently delete alert rules",
"stage": "GA",
"codeowner": "@grafana/alerting-squad",
"frontend": true,
"hideFromAdminPage": true,
"hideFromDocs": true,
"expression": "true"
}
},
{
"metadata": {
"name": "alertingRuleRecoverDeleted",