From 3466969a7c9343f4d6ca15496c8f45aa63e78015 Mon Sep 17 00:00:00 2001 From: Mario Trangoni Date: Thu, 18 Oct 2018 22:37:07 +0200 Subject: [PATCH] pkg/login/ldap.go: Fix warning comparison to bool constant See, $ gometalinter --vendor --deadline 10m --disable-all --enable=megacheck ./... pkg/login/ldap.go:188:40:warning: should omit comparison to bool constant, can be simplified to !*extUser.IsGrafanaAdmin (S1002) (megacheck) --- pkg/login/ldap.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/login/ldap.go b/pkg/login/ldap.go index 4c71ab3cd5f..d4e81d2bd46 100644 --- a/pkg/login/ldap.go +++ b/pkg/login/ldap.go @@ -185,7 +185,7 @@ func (a *ldapAuther) GetGrafanaUserFor(ctx *m.ReqContext, ldapUser *LdapUserInfo if ldapUser.isMemberOf(group.GroupDN) { extUser.OrgRoles[group.OrgId] = group.OrgRole - if extUser.IsGrafanaAdmin == nil || *extUser.IsGrafanaAdmin == false { + if extUser.IsGrafanaAdmin == nil || !*extUser.IsGrafanaAdmin { extUser.IsGrafanaAdmin = group.IsGrafanaAdmin } }