Hackaton: Add more unit tests, take 3 (#101525)

* serviceaccounts/secretscan: test Service more thoroughly

* middleware/cookies: add tests for CookieOptions

* anonymous/anonimpl: cover a couple more methods

* components/imguploader: Implement WebDAV integration tests

* components/apikeygen: also check IsValid method

* bus: cover invalid callback signature cases

* cloudmigration/objectstorage: add basic unit tests

* login/social/connectors: add test case for GitHub OAuth fetch emails+orgs

* expr/classic: cover more evaluator types in tests

pkg/expr/classic/evaluator_test.go

@@ -148,6 +148,54 @@ func TestRangedEvaluator(t *testing.T) {
 			inputNumber: newNumber(util.Pointer(50.0)),
 			expected:    false,
 		},
+		{
+			name:        "value 100 is outside range 1, 100: false",
+			evaluator:   &rangedEvaluator{"outside_range", 1, 100},
+			inputNumber: newNumber(util.Pointer(100.)),
+			expected:    false,
+		},
+		{
+			name:        "value 1 is outside range 1, 100: false",
+			evaluator:   &rangedEvaluator{"outside_range", 1, 100},
+			inputNumber: newNumber(util.Pointer(1.)),
+			expected:    false,
+		},
+		{
+			name:        "value 100 is within range included 1, 100: true",
+			evaluator:   &rangedEvaluator{"within_range_included", 1, 100},
+			inputNumber: newNumber(util.Pointer(100.)),
+			expected:    true,
+		},
+		{
+			name:        "value 1 is within range included 1, 100: true",
+			evaluator:   &rangedEvaluator{"within_range_included", 1, 100},
+			inputNumber: newNumber(util.Pointer(1.)),
+			expected:    true,
+		},
+		{
+			name:        "value 100 is outside range included 1, 100: true",
+			evaluator:   &rangedEvaluator{"outside_range_included", 1, 100},
+			inputNumber: newNumber(util.Pointer(100.)),
+			expected:    true,
+		},
+		{
+			name:        "value 1 is outside range included 1, 100: true",
+			evaluator:   &rangedEvaluator{"outside_range_included", 1, 100},
+			inputNumber: newNumber(util.Pointer(1.)),
+			expected:    true,
+		},
+		{
+			name:        "unknown evaluator type returns false",
+			evaluator:   &rangedEvaluator{"", 1, 100},
+			inputNumber: newNumber(util.Pointer(1.)),
+			expected:    false,
+		},
+		{
+			name:        "nil number conversion returns false",
+			evaluator:   &rangedEvaluator{"", 1, 100},
+			inputNumber: newNumber(nil),
+			expected:    false,
+		},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {