diff --git a/pkg/api/dtos/index.go b/pkg/api/dtos/index.go index 4aa50bc72f6..33f7ab84f78 100644 --- a/pkg/api/dtos/index.go +++ b/pkg/api/dtos/index.go @@ -15,6 +15,8 @@ type IndexViewData struct { NewGrafanaVersion string AppName string AppNameBodyClass string + FavIcon string + AppleTouchIcon string } type PluginCss struct { diff --git a/pkg/api/index.go b/pkg/api/index.go index dc192558145..05741f18437 100644 --- a/pkg/api/index.go +++ b/pkg/api/index.go @@ -85,6 +85,8 @@ func (hs *HTTPServer) setIndexViewData(c *m.ReqContext) (*dtos.IndexViewData, er NewGrafanaVersionExists: plugins.GrafanaHasUpdate, AppName: setting.ApplicationName, AppNameBodyClass: getAppNameBodyClass(hs.License.HasValidLicense()), + FavIcon: "public/img/fav32.png", + AppleTouchIcon: "public/img/apple-touch-icon.png", } if setting.DisableGravatar { diff --git a/public/app/core/components/Branding/Branding.tsx b/public/app/core/components/Branding/Branding.tsx index b1e193bdf21..bbf9cd03d3c 100644 --- a/public/app/core/components/Branding/Branding.tsx +++ b/public/app/core/components/Branding/Branding.tsx @@ -1,18 +1,23 @@ import React, { FC } from 'react'; export interface BrandComponentProps { - className: string; + className?: string; } -export const LogoIcon: FC = ({ className }) => { +export const LoginLogo: FC = ({ className }) => { + return ( + <> + Grafana +
+ + ); +}; + +export const MenuLogo: FC = ({ className }) => { return Grafana; }; -export const Wordmark: FC = ({ className }) => { - return
; -}; - export class Branding { - static LogoIcon = LogoIcon; - static Wordmark = Wordmark; + static LoginLogo = LoginLogo; + static MenuLogo = MenuLogo; } diff --git a/public/app/core/components/Login/LoginPage.tsx b/public/app/core/components/Login/LoginPage.tsx index 98ef1e4c9f2..2a50c573597 100644 --- a/public/app/core/components/Login/LoginPage.tsx +++ b/public/app/core/components/Login/LoginPage.tsx @@ -12,8 +12,7 @@ export const LoginPage: FC = () => {
- - +
{({ diff --git a/public/app/core/components/sidemenu/SideMenu.tsx b/public/app/core/components/sidemenu/SideMenu.tsx index 632b200438e..fc3cf6035b6 100644 --- a/public/app/core/components/sidemenu/SideMenu.tsx +++ b/public/app/core/components/sidemenu/SideMenu.tsx @@ -4,6 +4,7 @@ import TopSection from './TopSection'; import BottomSection from './BottomSection'; import config from 'app/core/config'; import { CoreEvents } from 'app/types'; +import { Branding } from 'app/core/components/Branding/Branding'; const homeUrl = config.appSubUrl || '/'; @@ -15,7 +16,7 @@ export class SideMenu extends PureComponent { render() { return [ - Grafana + ,
diff --git a/public/app/core/components/sidemenu/__snapshots__/SideMenu.test.tsx.snap b/public/app/core/components/sidemenu/__snapshots__/SideMenu.test.tsx.snap index 8d23cdc1565..859fc89ec1c 100644 --- a/public/app/core/components/sidemenu/__snapshots__/SideMenu.test.tsx.snap +++ b/public/app/core/components/sidemenu/__snapshots__/SideMenu.test.tsx.snap @@ -7,10 +7,7 @@ Array [ href="/" key="logo" > - Grafana + ,
- + + + -