From 37c960e1044203085cb8f0cabad4e5b8c707e770 Mon Sep 17 00:00:00 2001 From: mikkancso Date: Fri, 26 May 2023 10:15:16 +0200 Subject: [PATCH] Reword button to "Add new data source" (#69125) * reword button to Create a new data source The previous wording included the name of the data source, which made it difficult for the doc team to refer to it. This allows the doc team to refer to this button in an obvious way. * "Create a"-> "Add" * update tests --- .../GetStartedWithPlugin/GetStartedWithDataSource.tsx | 2 +- .../features/plugins/admin/pages/PluginDetails.test.tsx | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/public/app/features/plugins/admin/components/GetStartedWithPlugin/GetStartedWithDataSource.tsx b/public/app/features/plugins/admin/components/GetStartedWithPlugin/GetStartedWithDataSource.tsx index f4816ce8ac2..56cf7602f2e 100644 --- a/public/app/features/plugins/admin/components/GetStartedWithPlugin/GetStartedWithDataSource.tsx +++ b/public/app/features/plugins/admin/components/GetStartedWithPlugin/GetStartedWithDataSource.tsx @@ -30,7 +30,7 @@ export function GetStartedWithDataSource({ plugin }: Props): React.ReactElement return ( ); } diff --git a/public/app/features/plugins/admin/pages/PluginDetails.test.tsx b/public/app/features/plugins/admin/pages/PluginDetails.test.tsx index 24f2fdde934..ba4a8774fd5 100644 --- a/public/app/features/plugins/admin/pages/PluginDetails.test.tsx +++ b/public/app/features/plugins/admin/pages/PluginDetails.test.tsx @@ -513,7 +513,7 @@ describe('Plugin details page', () => { }); await waitFor(() => queryByText('Uninstall')); - expect(queryByText(`Create a ${name} data source`)).toBeInTheDocument(); + expect(queryByText('Add new data source')).toBeInTheDocument(); }); it('should not display a "Create" button as a post installation step for disabled data source plugins', async () => { @@ -526,7 +526,7 @@ describe('Plugin details page', () => { }); await waitFor(() => queryByText('Uninstall')); - expect(queryByText(`Create a ${name} data source`)).toBeNull(); + expect(queryByText('Add new data source')).toBeNull(); }); it('should not display post installation step for panel plugins', async () => { @@ -538,7 +538,7 @@ describe('Plugin details page', () => { }); await waitFor(() => queryByText('Uninstall')); - expect(queryByText(`Create a ${name} data source`)).toBeNull(); + expect(queryByText('Add new data source')).toBeNull(); }); it('should display an enable button for app plugins that are not enabled as a post installation step', async () => { @@ -787,7 +787,7 @@ describe('Plugin details page', () => { }); await waitFor(() => queryByText('Uninstall')); - expect(queryByText(`Create a ${name} data source`)).toBeNull(); + expect(queryByText('Add new data source')).toBeNull(); }); }); });