From 39a4634ae9e336eab505680416ca700c19c04d10 Mon Sep 17 00:00:00 2001 From: Stephanie Hingtgen Date: Wed, 8 Mar 2023 12:21:01 -0600 Subject: [PATCH] Plugins: Fix bug with copying grafanaData (#64446) --- pkg/services/datasources/service/datasource.go | 5 +++-- pkg/services/datasources/service/datasource_test.go | 4 ++++ 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/pkg/services/datasources/service/datasource.go b/pkg/services/datasources/service/datasource.go index 4be24fa75dc..2d3b01be8eb 100644 --- a/pkg/services/datasources/service/datasource.go +++ b/pkg/services/datasources/service/datasource.go @@ -424,10 +424,11 @@ func (s *Service) httpClientOptions(ctx context.Context, ds *datasources.DataSou if ds.JsonData != nil { opts.CustomOptions = ds.JsonData.MustMap() // allow the plugin sdk to get the json data in JSONDataFromHTTPClientOptions - opts.CustomOptions["grafanaData"] = make(map[string]interface{}) + deepJsonDataCopy := make(map[string]interface{}, len(opts.CustomOptions)) for k, v := range opts.CustomOptions { - opts.CustomOptions[k] = v + deepJsonDataCopy[k] = v } + opts.CustomOptions["grafanaData"] = deepJsonDataCopy } if ds.BasicAuth { password, err := s.DecryptedBasicAuthPassword(ctx, ds) diff --git a/pkg/services/datasources/service/datasource_test.go b/pkg/services/datasources/service/datasource_test.go index 1c8b0cf4228..44327ca0d42 100644 --- a/pkg/services/datasources/service/datasource_test.go +++ b/pkg/services/datasources/service/datasource_test.go @@ -427,6 +427,10 @@ func TestService_GetHttpTransport(t *testing.T) { require.NotNil(t, rt) tr := configuredTransport + opts, err := dsService.httpClientOptions(context.Background(), &ds) + require.NoError(t, err) + require.Equal(t, ds.JsonData.MustMap()["grafanaData"], opts.CustomOptions["grafanaData"]) + // make sure we can still marshal the JsonData after httpClientOptions (avoid cycles) _, err = ds.JsonData.MarshalJSON() require.NoError(t, err)