From 39db59fc73327879f83fc1b7453fbfff1e225fca Mon Sep 17 00:00:00 2001 From: Ashley Harrison Date: Fri, 14 Feb 2025 16:39:22 +0000 Subject: [PATCH] Chore: remove the `queryLibraryDashboards` toggle since we didn't end up using it (#100749) remove the queryLibraryDashboards toggle since we didn't end up using it --- .../configure-grafana/feature-toggles/index.md | 1 - packages/grafana-data/src/types/featureToggles.gen.ts | 1 - pkg/services/featuremgmt/registry.go | 7 ------- pkg/services/featuremgmt/toggles_gen.csv | 1 - pkg/services/featuremgmt/toggles_gen.go | 4 ---- pkg/services/featuremgmt/toggles_gen.json | 1 + 6 files changed, 1 insertion(+), 14 deletions(-) diff --git a/docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md b/docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md index 73143bc543b..169d0a6568d 100644 --- a/docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md +++ b/docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md @@ -228,7 +228,6 @@ Experimental features might be changed or removed without prior notice. | `k8SFolderMove` | Enable folder's api server move | | `teamHttpHeadersMimir` | Enables LBAC for datasources for Mimir to apply LBAC filtering of metrics to the client requests for users in teams | | `templateVariablesUsesCombobox` | Use new combobox component for template variables | -| `queryLibraryDashboards` | Enables Query Library feature in Dashboards | | `grafanaAdvisor` | Enables Advisor app | | `elasticsearchImprovedParsing` | Enables less memory intensive Elasticsearch result parsing | | `datasourceConnectionsTab` | Shows defined connections for a data source in the plugins detail page | diff --git a/packages/grafana-data/src/types/featureToggles.gen.ts b/packages/grafana-data/src/types/featureToggles.gen.ts index 9feb63a23eb..962d7d8a2d6 100644 --- a/packages/grafana-data/src/types/featureToggles.gen.ts +++ b/packages/grafana-data/src/types/featureToggles.gen.ts @@ -247,7 +247,6 @@ export interface FeatureToggles { ABTestFeatureToggleA?: boolean; templateVariablesUsesCombobox?: boolean; ABTestFeatureToggleB?: boolean; - queryLibraryDashboards?: boolean; grafanaAdvisor?: boolean; elasticsearchImprovedParsing?: boolean; exploreMetricsUseExternalAppPlugin?: boolean; diff --git a/pkg/services/featuremgmt/registry.go b/pkg/services/featuremgmt/registry.go index f8d16934988..f8e39774f11 100644 --- a/pkg/services/featuremgmt/registry.go +++ b/pkg/services/featuremgmt/registry.go @@ -1716,13 +1716,6 @@ var ( Expression: "false", HideFromDocs: true, }, - { - Name: "queryLibraryDashboards", - Description: "Enables Query Library feature in Dashboards", - Stage: FeatureStageExperimental, - Owner: grafanaFrontendPlatformSquad, - AllowSelfServe: false, - }, { Name: "grafanaAdvisor", Description: "Enables Advisor app", diff --git a/pkg/services/featuremgmt/toggles_gen.csv b/pkg/services/featuremgmt/toggles_gen.csv index 1a356254544..b835fc5cc53 100644 --- a/pkg/services/featuremgmt/toggles_gen.csv +++ b/pkg/services/featuremgmt/toggles_gen.csv @@ -228,7 +228,6 @@ teamHttpHeadersMimir,experimental,@grafana/identity-access-team,false,false,fals ABTestFeatureToggleA,experimental,@grafana/sharing-squad,false,false,false templateVariablesUsesCombobox,experimental,@grafana/grafana-frontend-platform,false,false,true ABTestFeatureToggleB,experimental,@grafana/sharing-squad,false,false,false -queryLibraryDashboards,experimental,@grafana/grafana-frontend-platform,false,false,false grafanaAdvisor,experimental,@grafana/plugins-platform-backend,false,false,false elasticsearchImprovedParsing,experimental,@grafana/aws-datasources,false,false,false exploreMetricsUseExternalAppPlugin,experimental,@grafana/observability-metrics,false,true,true diff --git a/pkg/services/featuremgmt/toggles_gen.go b/pkg/services/featuremgmt/toggles_gen.go index 49d0bbb3f33..692b13683e5 100644 --- a/pkg/services/featuremgmt/toggles_gen.go +++ b/pkg/services/featuremgmt/toggles_gen.go @@ -923,10 +923,6 @@ const ( // Test feature toggle to see how cohorts could be set up AB testing FlagABTestFeatureToggleB = "ABTestFeatureToggleB" - // FlagQueryLibraryDashboards - // Enables Query Library feature in Dashboards - FlagQueryLibraryDashboards = "queryLibraryDashboards" - // FlagGrafanaAdvisor // Enables Advisor app FlagGrafanaAdvisor = "grafanaAdvisor" diff --git a/pkg/services/featuremgmt/toggles_gen.json b/pkg/services/featuremgmt/toggles_gen.json index 94bd2a033c3..ea5d965d4ac 100644 --- a/pkg/services/featuremgmt/toggles_gen.json +++ b/pkg/services/featuremgmt/toggles_gen.json @@ -3424,6 +3424,7 @@ "name": "queryLibraryDashboards", "resourceVersion": "1736850377404", "creationTimestamp": "2025-01-14T11:01:15Z", + "deletionTimestamp": "2025-02-14T16:06:41Z", "annotations": { "grafana.app/updatedTimestamp": "2025-01-14 10:26:17.404592 +0000 UTC" }