public/grafana
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

API: return resource ID when deleting datasource with UID and library element (#41342)

Browse Source 
* API: return resource ID when deleting datasource and library element

* keep status codes consistent

* fix element ID

* add test

* improve response struct

* update endpoints documentation

* LibraryElementIDResponse -> DeleteLibraryElementResponse
This commit is contained in:
Agnès Toulet
2021-11-05 15:06:14 +01:00
committed by GitHub
parent e0ad74a815
commit 3a6b8535b1
7 changed files with 34 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/services/libraryelements/api.go
+5 -2
View File
@@ -35,12 +35,15 @@ func (l *LibraryElementService) createHandler(c *models.ReqContext, cmd CreateLi
// deleteHandler handles DELETE /api/library-elements/:uid.
func (l *LibraryElementService) deleteHandler(c *models.ReqContext) response.Response {
err := l.deleteLibraryElement(c.Req.Context(), c.SignedInUser, web.Params(c.Req)[":uid"])
id, err := l.deleteLibraryElement(c.Req.Context(), c.SignedInUser, web.Params(c.Req)[":uid"])
if err != nil {
return toLibraryElementError(err, "Failed to delete library element")
}
return response.Success("Library element deleted")
return response.JSON(200, DeleteLibraryElementResponse{
Message: "Library element deleted",
ID: id,
})
}
// getHandler handles GET /api/library-elements/:uid.