diff --git a/public/app/features/explore/TraceView/TraceView.tsx b/public/app/features/explore/TraceView/TraceView.tsx index fdba79cf86a..22bc6555ffd 100644 --- a/public/app/features/explore/TraceView/TraceView.tsx +++ b/public/app/features/explore/TraceView/TraceView.tsx @@ -48,10 +48,6 @@ const getStyles = (theme: GrafanaTheme2) => ({ `, }); -function noop(): {} { - return {}; -} - type Props = { dataFrames: DataFrame[]; splitOpenFn?: SplitOpen; @@ -165,7 +161,6 @@ export function TraceView(props: Props) { updateViewRangeTime={updateViewRangeTime} /> | TNil; - registerAccessors: (accesors: Accessors) => void; trace: Trace; spanBarOptions: SpanBarOptions | undefined; linksGetter: (span: TraceSpan, items: TraceKeyValuePair[], itemIndex: number) => TraceLink[]; @@ -219,17 +217,7 @@ export class UnthemedVirtualizedTraceView extends React.Component) { - const { registerAccessors } = prevProps; - const { - registerAccessors: nextRegisterAccessors, - headerHeight, - focusedSpanId, - focusedSpanIdForSearch, - } = this.props; - - if (this.listView && registerAccessors !== nextRegisterAccessors) { - nextRegisterAccessors(this.getAccessors()); - } + const { headerHeight, focusedSpanId, focusedSpanIdForSearch } = this.props; if (!this.hasScrolledToSpan) { this.scrollToSpan(headerHeight, focusedSpanId); @@ -305,11 +293,7 @@ export class UnthemedVirtualizedTraceView extends React.Component { - const isChanged = this.listView !== listView; this.listView = listView; - if (listView && isChanged) { - this.props.registerAccessors(this.getAccessors()); - } }; // use long form syntax to avert flow error diff --git a/public/app/features/explore/TraceView/components/TraceTimelineViewer/index.test.tsx b/public/app/features/explore/TraceView/components/TraceTimelineViewer/index.test.tsx index 0a7f4322438..f808228710b 100644 --- a/public/app/features/explore/TraceView/components/TraceTimelineViewer/index.test.tsx +++ b/public/app/features/explore/TraceView/components/TraceTimelineViewer/index.test.tsx @@ -49,7 +49,6 @@ describe('', () => { expandAll: jest.fn(), collapseAll: jest.fn(), expandOne: jest.fn(), - registerAccessors: jest.fn(), collapseOne: jest.fn(), theme: createTheme(), history: { diff --git a/public/app/features/explore/TraceView/components/TraceTimelineViewer/index.tsx b/public/app/features/explore/TraceView/components/TraceTimelineViewer/index.tsx index cfcd661f908..fa9e36875d9 100644 --- a/public/app/features/explore/TraceView/components/TraceTimelineViewer/index.tsx +++ b/public/app/features/explore/TraceView/components/TraceTimelineViewer/index.tsx @@ -19,7 +19,6 @@ import { GrafanaTheme2, LinkModel, TimeZone } from '@grafana/data'; import { config, reportInteraction } from '@grafana/runtime'; import { stylesFactory, withTheme2 } from '@grafana/ui'; -import { Accessors } from '../ScrollManager'; import { autoColor } from '../Theme'; import { merge as mergeShortcuts } from '../keyboard-shortcuts'; import { SpanBarOptions } from '../settings/SpanBarSettings'; @@ -68,7 +67,6 @@ const getStyles = stylesFactory((theme: GrafanaTheme2) => { }); export type TProps = { - registerAccessors: (accessors: Accessors) => void; findMatchesIDs: Set | TNil; traceTimeline: TTraceTimeline; trace: Trace;