Chore: Upgrade golangci-lint to v1.51.2 (#63630)

Co-authored-by: Sofia Papagiannaki <1632407+papagian@users.noreply.github.com>

pkg/services/sqlstore/migrations/accesscontrol/dashboard_permissions.go

@@ -150,9 +150,7 @@ func (m dashboardPermissionsMigrator) migratePermissions(dashes []dashboard, acl
 		return fmt.Errorf("failed to bulk-create roles: %w", err)
 	}
 
-	for i := range createdRoles {
-		allRoles = append(allRoles, createdRoles[i])
-	}
+	allRoles = append(allRoles, createdRoles...)
 
 	if err := m.bulkAssignRoles(createdRoles); err != nil {
 		return fmt.Errorf("failed to bulk-assign roles: %w", err)

pkg/services/sqlstore/session_test.go

@@ -66,6 +66,10 @@ func TestRetryingOnFailures(t *testing.T) {
 	// Check SQL query
 	sess := store.GetSqlxSession()
 	rows, err := sess.Query(context.Background(), `SELECT "hello",2.3,4`)
+	t.Cleanup(func() {
+		err := rows.Close()
+		require.NoError(t, err)
+	})
 	require.NoError(t, err)
 	require.True(t, rows.Next()) // first row