Chore: Upgrade golangci-lint to v1.51.2 (#63630)

Co-authored-by: Sofia Papagiannaki <1632407+papagian@users.noreply.github.com>

pkg/tsdb/azuremonitor/loganalytics/azure-log-analytics-datasource.go

@@ -178,6 +178,13 @@ func (e *AzureLogAnalyticsDatasource) executeQuery(ctx context.Context, logger l
 		return dataResponseErrorWithExecuted(err)
 	}
 
+	defer func() {
+		err := res.Body.Close()
+		if err != nil {
+			logger.Warn("failed to close response body", "error", err)
+		}
+	}()
+
 	logResponse, err := e.unmarshalResponse(logger, res)
 	if err != nil {
 		return dataResponseErrorWithExecuted(err)

pkg/tsdb/azuremonitor/resourcegraph/azure-resource-graph-datasource.go

@@ -183,6 +183,13 @@ func (e *AzureResourceGraphDatasource) executeQuery(ctx context.Context, logger
 		return dataResponseErrorWithExecuted(err)
 	}
 
+	defer func() {
+		err := res.Body.Close()
+		if err != nil {
+			logger.Warn("failed to close response body", "error", err)
+		}
+	}()
+
 	argResponse, err := e.unmarshalResponse(logger, res)
 	if err != nil {
 		return dataResponseErrorWithExecuted(err)

pkg/tsdb/cloudmonitoring/utils.go

@@ -15,10 +15,11 @@ import (
 
 	"github.com/grafana/grafana-plugin-sdk-go/backend"
 	"github.com/grafana/grafana-plugin-sdk-go/data"
+	"go.opentelemetry.io/otel/attribute"
+
 	"github.com/grafana/grafana/pkg/infra/log"
 	"github.com/grafana/grafana/pkg/infra/tracing"
 	"github.com/grafana/grafana/pkg/tsdb/intervalv2"
-	"go.opentelemetry.io/otel/attribute"
 )
 
 func addInterval(period string, field *data.Field) error {
@@ -86,6 +87,11 @@ func doRequestPage(ctx context.Context, logger log.Logger, r *http.Request, dsIn
 		return cloudMonitoringResponse{}, err
 	}
 
+	defer func() {
+		err := res.Body.Close()
+		logger.Warn("failed to close response body", "error", err)
+	}()
+
 	dnext, err := unmarshalResponse(logger, res)
 	if err != nil {
 		return cloudMonitoringResponse{}, err

pkg/tsdb/graphite/graphite.go

@@ -161,6 +161,13 @@ func (s *Service) QueryData(ctx context.Context, req *backend.QueryDataRequest)
 		return &result, err
 	}
 
+	defer func() {
+		err := res.Body.Close()
+		if err != nil {
+			logger.Warn("failed to close response body", "error", err)
+		}
+	}()
+
 	frames, err := s.toDataFrames(logger, res, origRefIds)
 	if err != nil {
 		span.RecordError(err)

pkg/tsdb/opentsdb/opentsdb.go

@@ -98,6 +98,13 @@ func (s *Service) QueryData(ctx context.Context, req *backend.QueryDataRequest)
 		return &backend.QueryDataResponse{}, err
 	}
 
+	defer func() {
+		err := res.Body.Close()
+		if err != nil {
+			logger.Warn("failed to close response body", "error", err)
+		}
+	}()
+
 	result, err := s.parseResponse(logger, res)
 	if err != nil {
 		return &backend.QueryDataResponse{}, err

pkg/tsdb/prometheus/querydata/request.go

@@ -153,6 +153,13 @@ func (s *QueryData) fetch(ctx context.Context, client *client.Client, q *models.
 
 func (s *QueryData) rangeQuery(ctx context.Context, c *client.Client, q *models.Query, headers map[string]string) backend.DataResponse {
 	res, err := c.QueryRange(ctx, q)
+	defer func() {
+		err := res.Body.Close()
+		if err != nil {
+			s.log.Warn("failed to close query range response body", "error", err)
+		}
+	}()
+
 	if err != nil {
 		return backend.DataResponse{
 			Error: err,
@@ -163,6 +170,13 @@ func (s *QueryData) rangeQuery(ctx context.Context, c *client.Client, q *models.
 
 func (s *QueryData) instantQuery(ctx context.Context, c *client.Client, q *models.Query, headers map[string]string) backend.DataResponse {
 	res, err := c.QueryInstant(ctx, q)
+	defer func() {
+		err := res.Body.Close()
+		if err != nil {
+			s.log.Warn("failed to close response body", "error", err)
+		}
+	}()
+
 	if err != nil {
 		return backend.DataResponse{
 			Error: err,
@@ -173,6 +187,13 @@ func (s *QueryData) instantQuery(ctx context.Context, c *client.Client, q *model
 
 func (s *QueryData) exemplarQuery(ctx context.Context, c *client.Client, q *models.Query, headers map[string]string) backend.DataResponse {
 	res, err := c.QueryExemplars(ctx, q)
+	defer func() {
+		err := res.Body.Close()
+		if err != nil {
+			s.log.Warn("failed to close response body", "error", err)
+		}
+	}()
+
 	if err != nil {
 		return backend.DataResponse{
 			Error: err,

pkg/tsdb/prometheus/querydata/request_test.go

@@ -357,12 +357,17 @@ func executeWithHeaders(tctx *testContext, query backend.DataQuery, qr interface
 	if err != nil {
 		return nil, err
 	}
+
 	tctx.httpProvider.setResponse(promRes)
 
 	res, err := tctx.queryData.Execute(context.Background(), &req)
+	errClose := promRes.Body.Close()
 	if err != nil {
 		return nil, err
 	}
+	if errClose != nil {
+		return nil, errClose
+	}
 
 	return res.Responses[req.Queries[0].RefID].Frames, nil
 }