From 3af891d02358504f9d19b0481b09a3454f0052af Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Torkel=20=C3=96degaard?= Date: Tue, 13 Sep 2016 16:13:41 +0200 Subject: [PATCH] feat(alerting): restored alert history --- pkg/services/sqlstore/annotation.go | 6 ++++-- public/app/features/alerting/alert_tab_ctrl.ts | 2 +- public/app/features/alerting/partials/alert_tab.html | 7 +++---- 3 files changed, 8 insertions(+), 7 deletions(-) diff --git a/pkg/services/sqlstore/annotation.go b/pkg/services/sqlstore/annotation.go index b604b0de44f..88152af4ce0 100644 --- a/pkg/services/sqlstore/annotation.go +++ b/pkg/services/sqlstore/annotation.go @@ -53,8 +53,10 @@ func (r *SqlAnnotationRepo) Find(query *annotations.ItemQuery) ([]*annotations.I params = append(params, query.PanelId) } - sql.WriteString(` AND epoch BETWEEN ? AND ?`) - params = append(params, query.From, query.To) + if query.From > 0 && query.To > 0 { + sql.WriteString(` AND epoch BETWEEN ? AND ?`) + params = append(params, query.From, query.To) + } if query.Type != "" { sql.WriteString(` AND type = ?`) diff --git a/public/app/features/alerting/alert_tab_ctrl.ts b/public/app/features/alerting/alert_tab_ctrl.ts index e71b7686d5c..62ac4c00e46 100644 --- a/public/app/features/alerting/alert_tab_ctrl.ts +++ b/public/app/features/alerting/alert_tab_ctrl.ts @@ -86,7 +86,7 @@ export class AlertTabCtrl { } getAlertHistory() { - this.backendSrv.get(`/api/alert-history?dashboardId=${this.panelCtrl.dashboard.id}&panelId=${this.panel.id}&limit=50`).then(res => { + this.backendSrv.get(`/api/annotations?dashboardId=${this.panelCtrl.dashboard.id}&panelId=${this.panel.id}&limit=50`).then(res => { this.alertHistory = _.map(res, ah => { ah.time = moment(ah.timestamp).format('MMM D, YYYY HH:mm:ss'); ah.stateModel = alertDef.getStateDisplayModel(ah.newState); diff --git a/public/app/features/alerting/partials/alert_tab.html b/public/app/features/alerting/partials/alert_tab.html index 434605ffe5e..3d6e183d93f 100644 --- a/public/app/features/alerting/partials/alert_tab.html +++ b/public/app/features/alerting/partials/alert_tab.html @@ -27,11 +27,10 @@
Alert Config
- Name - - Evaluate every + Name + + Evaluate every -