From 3bb4e24458124acc65433edb62f5ebe04211daf9 Mon Sep 17 00:00:00 2001
From: Fabrizio <135109076+fabrizio-grafana@users.noreply.github.com>
Date: Sat, 9 Sep 2023 14:11:36 +0200
Subject: [PATCH] Dashboards: Escape tags (#74437)

---
 .../datasource/tempo/language_provider.ts      | 18 ++++++++++++++++--
 1 file changed, 16 insertions(+), 2 deletions(-)

diff --git a/public/app/plugins/datasource/tempo/language_provider.ts b/public/app/plugins/datasource/tempo/language_provider.ts
index f17074f4053..968259d6326 100644
--- a/public/app/plugins/datasource/tempo/language_provider.ts
+++ b/public/app/plugins/datasource/tempo/language_provider.ts
@@ -118,7 +118,8 @@ export default class TempoLanguageProvider extends LanguageProvider {
   };
 
   async getOptionsV1(tag: string): Promise<Array<SelectableValue<string>>> {
-    const response = await this.request(`/api/search/tag/${tag}/values`);
+    const encodedTag = this.encodeTag(tag);
+    const response = await this.request(`/api/search/tag/${encodedTag}/values`);
     let options: Array<SelectableValue<string>> = [];
     if (response && response.tagValues) {
       options = response.tagValues.map((v: string) => ({
@@ -130,7 +131,8 @@ export default class TempoLanguageProvider extends LanguageProvider {
   }
 
   async getOptionsV2(tag: string, query?: string): Promise<Array<SelectableValue<string>>> {
-    const response = await this.request(`/api/v2/search/tag/${tag}/values`, query ? { q: query } : {});
+    const encodedTag = this.encodeTag(tag);
+    const response = await this.request(`/api/v2/search/tag/${encodedTag}/values`, query ? { q: query } : {});
     let options: Array<SelectableValue<string>> = [];
     if (response && response.tagValues) {
       response.tagValues.forEach((v: { type: string; value?: string }) => {
@@ -145,4 +147,16 @@ export default class TempoLanguageProvider extends LanguageProvider {
     }
     return options;
   }
+
+  /**
+   * Encode (serialize) a given tag for use in a URL.
+   *
+   * @param tag the tag to encode
+   * @returns the encoded tag
+   */
+  private encodeTag = (tag: string): string => {
+    // If we call `encodeURIComponent` only once, we still get an error when issuing a request to the backend
+    // Reference: https://stackoverflow.com/a/37456192
+    return encodeURIComponent(encodeURIComponent(tag));
+  };
 }