Chore: removing some type assertions (#85839)

* fix some type assertions in loops

* some more cleanup

* some alerting fixes

* put comments in correct place to ignore rule

* couple more

* undo SilencesFilter changes

packages/grafana-data/src/dataframe/DataFrameJSON.ts

@@ -128,9 +128,10 @@ const ENTITY_MAP: Record<keyof FieldValueEntityLookup, number | undefined> = {
  * @internal use locally
  */
 export function decodeFieldValueEntities(lookup: FieldValueEntityLookup, values: FieldValues) {
-  for (const key in lookup) {
-    const repl = ENTITY_MAP[key as keyof FieldValueEntityLookup];
-    for (const idx of lookup[key as keyof FieldValueEntityLookup]!) {
+  let key: keyof typeof lookup;
+  for (key in lookup) {
+    const repl = ENTITY_MAP[key];
+    for (const idx of lookup[key]!) {
       if (idx < values.length) {
         values[idx] = repl;
       }

packages/grafana-data/src/dataframe/StreamingDataFrame.ts

@@ -115,7 +115,7 @@ export class StreamingDataFrame implements DataFrame {
     const dataFrameDTO = toFilteredDataFrameDTO(this, fieldPredicate);
 
     const numberOfItemsToRemove = getNumberOfItemsToRemove(
-      dataFrameDTO.fields.map((f) => f.values) as unknown[][],
+      dataFrameDTO.fields.map((f) => f.values ?? []),
       typeof trimValues?.maxLength === 'number' ? Math.min(trimValues.maxLength, options.maxLength) : options.maxLength,
       this.timeFieldIndex,
       options.maxDelta

packages/grafana-data/src/dataframe/frameComparisons.ts

@@ -46,18 +46,12 @@ export function compareDataFrameStructures(a: DataFrame, b: DataFrame, skipConfi
     const cfgA = fA.config;
     const cfgB = fB.config;
 
-    // need to type assert on the object keys here
-    // see e.g. https://github.com/Microsoft/TypeScript/issues/12870
-    // eslint-disable-next-line @typescript-eslint/consistent-type-assertions
-    let aKeys = Object.keys(cfgA) as Array<keyof typeof cfgA>;
-    // eslint-disable-next-line @typescript-eslint/consistent-type-assertions
-    let bKeys = Object.keys(cfgB) as Array<keyof typeof cfgB>;
-
-    if (aKeys.length !== bKeys.length) {
+    if (Object.keys(cfgA).length !== Object.keys(cfgB).length) {
       return false;
     }
 
-    for (const key of aKeys) {
+    let key: keyof typeof cfgA;
+    for (key in cfgA) {
       if (!(key in cfgB)) {
         return false;
       }
@@ -110,15 +104,12 @@ export function shallowCompare<T extends {}>(a: T, b: T, cmp: Cmp = defaultCmp)
     return true;
   }
 
-  const aKeys = Object.keys(a);
-  const bKeys = Object.keys(b);
-
-  if (aKeys.length !== bKeys.length) {
+  if (Object.keys(a).length !== Object.keys(b).length) {
     return false;
   }
 
-  for (let key of aKeys) {
-    //@ts-ignore
+  let key: keyof typeof a;
+  for (key in a) {
     if (!cmp(a[key], b[key])) {
       return false;
     }