pkg/web: restrict handler types (#48495)

Makes `pkg/web` only accept handles from the following set:

```go
	handlerStd       = func(http.ResponseWriter, *http.Request)
	handlerStdCtx    = func(http.ResponseWriter, *http.Request, *web.Context)
	handlerStdReqCtx = func(http.ResponseWriter, *http.Request, *models.ReqContext)
	handlerReqCtx    = func(*models.ReqContext)
	handlerReqCtxRes = func(*models.ReqContext) Response
	handlerCtx       = func(*web.Context)
```

This is a first step to reducing above set to only `http.Handler`.

---

Due to a cyclic import situation between `pkg/models` and `pkg/web`, parts of this PR were put into `pkg/api/response`, even though they definitely do not belong there. This however is _temporary_ until we untangle `models.ReqContext`.

This commit is contained in:

sh0rez

2022-05-20 12:45:18 -04:00

committed by

GitHub

parent c980655f08

commit 3d5d8c785b

13 changed files with 115 additions and 23 deletions

									
										pkg/web/macaron.s
									
		+2
		
												View File
												
				@@ -0,0 +1,2 @@

				// ./hack/hack.go pushes its Wrap function as hack_wrap into this package.

				// This .s file is required to allow hack_wrap to be defined without having a function body.