public/grafana
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Chore: assign feature flag ownership for GaaS (#64420)

Browse Source 
* ownership for GaaS

* fix tests

* merge
This commit is contained in:
Artur Wierzbicki
2023-03-08 12:25:12 -05:00
committed by GitHub
parent 74ed7ead16
commit 3e89ffa2e6
3 changed files with 15 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/services/featuremgmt/codeowners.go
+1
View File
@@ -18,4 +18,5 @@ const (
grafanaObservabilityLogsSquad codeowner = "@grafana/observability-logs" grafanaObservabilityLogsSquad codeowner = "@grafana/observability-logs"
grafanaObservabilityTracesAndProfilingSquad codeowner = "@grafana/observability-traces-and-profiling" grafanaObservabilityTracesAndProfilingSquad codeowner = "@grafana/observability-traces-and-profiling"
grafanaAlertingSquad codeowner = "@grafana/alerting-squad" grafanaAlertingSquad codeowner = "@grafana/alerting-squad"
hostedGrafanaTeam codeowner = "@grafana/hosted-grafana-team"
) )
pkg/services/featuremgmt/registry.go
+4
View File
@@ -31,6 +31,7 @@ var (
Name: "database_metrics", Name: "database_metrics",
Description: "Add Prometheus metrics for database tables", Description: "Add Prometheus metrics for database tables",
State: FeatureStateStable, State: FeatureStateStable,
Owner: hostedGrafanaTeam,
}, },
{ {
Name: "dashboardPreviews", Name: "dashboardPreviews",
@@ -228,11 +229,13 @@ var (
Description: "Disable duplicated secret storage in legacy tables", Description: "Disable duplicated secret storage in legacy tables",
State: FeatureStateAlpha, State: FeatureStateAlpha,
RequiresRestart: true, RequiresRestart: true,
Owner: hostedGrafanaTeam,
}, },
{ {
Name: "logRequestsInstrumentedAsUnknown", Name: "logRequestsInstrumentedAsUnknown",
Description: "Logs the path for requests that are instrumented as unknown", Description: "Logs the path for requests that are instrumented as unknown",
State: FeatureStateAlpha, State: FeatureStateAlpha,
Owner: hostedGrafanaTeam,
}, },
{ {
Name: "dataConnectionsConsole", Name: "dataConnectionsConsole",
@@ -343,6 +346,7 @@ var (
Name: "secureSocksDatasourceProxy", Name: "secureSocksDatasourceProxy",
Description: "Enable secure socks tunneling for supported core datasources", Description: "Enable secure socks tunneling for supported core datasources",
State: FeatureStateAlpha, State: FeatureStateAlpha,
Owner: hostedGrafanaTeam,
}, },
{ {
Name: "authnService", Name: "authnService",
pkg/services/featuremgmt/toggles_gen_test.go
+10 -14
View File
@@ -42,20 +42,16 @@ func TestFeatureToggleFiles(t *testing.T) {
}) })
ownerlessFeatures := map[string]bool{ ownerlessFeatures := map[string]bool{
"database_metrics": true, "prometheusAzureOverrideAudience": true,
"prometheusAzureOverrideAudience": true, "tracing": true,
"tracing": true, "cloudWatchDynamicLabels": true,
"cloudWatchDynamicLabels": true, "cloudWatchCrossAccountQuerying": true,
"disableSecretsCompatibility": true, "redshiftAsyncQueryDataSupport": true,
"logRequestsInstrumentedAsUnknown": true, "athenaAsyncQueryDataSupport": true,
"cloudWatchCrossAccountQuerying": true, "newPanelChromeUI": true,
"redshiftAsyncQueryDataSupport": true, "showDashboardValidationWarnings": true,
"athenaAsyncQueryDataSupport": true, "datasourceOnboarding": true,
"newPanelChromeUI": true, "individualCookiePreferences": true,
"showDashboardValidationWarnings": true,
"datasourceOnboarding": true,
"secureSocksDatasourceProxy": true,
"individualCookiePreferences": true,
} }
t.Run("all new features should have an owner", func(t *testing.T) { t.Run("all new features should have an owner", func(t *testing.T) {