From 3ea63a1064c162c8b245234d925017f98d6effe5 Mon Sep 17 00:00:00 2001
From: Daniel Lee <dan.limerick@gmail.com>
Date: Tue, 9 Jan 2018 14:42:42 +0100
Subject: [PATCH] fix for unsaved changes popup on tab close/refresh

Incorrect return values in onbeforeunload event handler mean that the
unsaved changes popup is shown despite there being no changes.
---
 public/app/features/dashboard/unsaved_changes_srv.ts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/public/app/features/dashboard/unsaved_changes_srv.ts b/public/app/features/dashboard/unsaved_changes_srv.ts
index adf808b9bf0..12eebb1077f 100644
--- a/public/app/features/dashboard/unsaved_changes_srv.ts
+++ b/public/app/features/dashboard/unsaved_changes_srv.ts
@@ -35,12 +35,12 @@ export class Tracker {
 
     $window.onbeforeunload = () => {
       if (this.ignoreChanges()) {
-        return '';
+        return null;
       }
       if (this.hasChanges()) {
         return 'There are unsaved changes to this dashboard';
       }
-      return '';
+      return null;
     };
 
     scope.$on('$locationChangeStart', (event, next) => {