Authz: Remove "wrapper" interface and only check feature toggle for grpc mode (#98933)

* Remove "wrapper" interface and only check feature toggle for grpc and cloud mode

* Only set name for update checks

* Set dashboard permissions for admin user

pkg/services/authz/client.go

@@ -2,6 +2,7 @@ package authz
 
 import (
 	"context"
+	"errors"
 
 	"github.com/fullstorydev/grpchan"
 	"github.com/fullstorydev/grpchan/inprocgrpc"
@@ -27,56 +28,40 @@ import (
 // `authzService` is hardcoded in authz-service
 const authzServiceAudience = "authzService"
 
-type Client interface {
-	authzlib.AccessClient
-}
-
 // ProvideAuthZClient provides an AuthZ client and creates the AuthZ service.
 func ProvideAuthZClient(
 	cfg *setting.Cfg, features featuremgmt.FeatureToggles, grpcServer grpcserver.Provider,
 	tracer tracing.Tracer, db db.DB,
-) (Client, error) {
-	if !features.IsEnabledGlobally(featuremgmt.FlagAuthZGRPCServer) {
-		return nil, nil
-	}
-
+) (authzlib.AccessClient, error) {
 	authCfg, err := ReadCfg(cfg)
 	if err != nil {
 		return nil, err
 	}
 
-	var client Client
+	isRemoteServer := authCfg.mode == ModeCloud || authCfg.mode == ModeGRPC
+	if !features.IsEnabledGlobally(featuremgmt.FlagAuthZGRPCServer) && isRemoteServer {
+		return nil, errors.New("authZGRPCServer feature toggle is required for cloud and grpc mode")
+	}
 
 	// Register the server
 	sql := legacysql.NewDatabaseProvider(db)
 	server := rbac.NewService(sql, legacy.NewLegacySQLStores(sql), log.New("authz-grpc-server"), tracer)
 
 	switch authCfg.mode {
-	case ModeInProc:
-		client, err = newInProcLegacyClient(server, tracer)
-		if err != nil {
-			return nil, err
-		}
 	case ModeGRPC:
-		client, err = newGrpcLegacyClient(authCfg, tracer)
-		if err != nil {
-			return nil, err
-		}
+		return newGrpcLegacyClient(authCfg, tracer)
 	case ModeCloud:
-		client, err = newCloudLegacyClient(authCfg, tracer)
-		if err != nil {
-			return nil, err
-		}
+		return newCloudLegacyClient(authCfg, tracer)
+	default:
+		return newInProcLegacyClient(server, tracer)
 	}
-
-	return client, err
 }
 
 // ProvideStandaloneAuthZClient provides a standalone AuthZ client, without registering the AuthZ service.
 // You need to provide a remote address in the configuration
 func ProvideStandaloneAuthZClient(
 	cfg *setting.Cfg, features featuremgmt.FeatureToggles, tracer tracing.Tracer,
-) (Client, error) {
+) (authzlib.AccessClient, error) {
 	if !features.IsEnabledGlobally(featuremgmt.FlagAuthZGRPCServer) {
 		return nil, nil
 	}