public/grafana
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

PublicDashboards: Enable feature by default for GA and remove public preview text (#76484)

Browse Source 
* public dashboard for GA

* files modified

* public preview removed
This commit is contained in:
Juan Cabanas
2023-10-13 16:32:49 +02:00
committed by GitHub
parent a42040a59a
commit 40b79de0cd
6 changed files with 6 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/sources/dashboards/dashboard-public/index.md
-6
View File
@@ -13,12 +13,6 @@ weight: 8
# Public dashboards # Public dashboards
{{% admonition type="note" %}}
This feature is in [public preview](/docs/release-life-cycle/).
{{% /admonition %}}
> **Warning:** Making your dashboard public could result in a large number of queries to the data sources used by your dashboard. > **Warning:** Making your dashboard public could result in a large number of queries to the data sources used by your dashboard.
> This can be mitigated by utilizing the enterprise [caching][] and/or rate limiting features. > This can be mitigated by utilizing the enterprise [caching][] and/or rate limiting features.
docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md
+1 -1
View File
@@ -22,6 +22,7 @@ Some features are enabled by default. You can disable these feature by setting t
| Feature toggle name | Description | Enabled by default | | Feature toggle name | Description | Enabled by default |
| ------------------------------------------------ | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ------------------ | | ------------------------------------------------ | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ------------------ |
| `disableEnvelopeEncryption` | Disable envelope encryption (emergency only) | | | `disableEnvelopeEncryption` | Disable envelope encryption (emergency only) | |
| `publicDashboards` | Enables public access to dashboards | Yes |
| `featureHighlights` | Highlight Grafana Enterprise features | | | `featureHighlights` | Highlight Grafana Enterprise features | |
| `dataConnectionsConsole` | Enables a new top-level page called Connections. This page is an experiment that provides a better experience when you install and configure data sources and other plugins. | Yes | | `dataConnectionsConsole` | Enables a new top-level page called Connections. This page is an experiment that provides a better experience when you install and configure data sources and other plugins. | Yes |
| `cloudWatchCrossAccountQuerying` | Enables cross-account querying in CloudWatch datasources | Yes | | `cloudWatchCrossAccountQuerying` | Enables cross-account querying in CloudWatch datasources | Yes |
@@ -58,7 +59,6 @@ Some features are enabled by default. You can disable these feature by setting t
| -------------------------------- | -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | | -------------------------------- | -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| `trimDefaults` | Use cue schema to remove values that will be applied automatically | | `trimDefaults` | Use cue schema to remove values that will be applied automatically |
| `panelTitleSearch` | Search for dashboards using panel title | | `panelTitleSearch` | Search for dashboards using panel title |
| `publicDashboards` | Enables public access to dashboards |
| `migrationLocking` | Lock database during migrations | | `migrationLocking` | Lock database during migrations |
| `correlations` | Correlations page | | `correlations` | Correlations page |
| `newDBLibrary` | Use jmoiron/sqlx rather than xorm for a few backend services | | `newDBLibrary` | Use jmoiron/sqlx rather than xorm for a few backend services |
pkg/services/featuremgmt/registry.go
+2 -1
View File
@@ -44,8 +44,9 @@ var (
{ {
Name: "publicDashboards", Name: "publicDashboards",
Description: "Enables public access to dashboards", Description: "Enables public access to dashboards",
Stage: FeatureStagePublicPreview, Stage: FeatureStageGeneralAvailability,
Owner: grafanaSharingSquad, Owner: grafanaSharingSquad,
Expression: "true", // enabled by default
}, },
{ {
Name: "publicDashboardsEmailSharing", Name: "publicDashboardsEmailSharing",
pkg/services/featuremgmt/toggles_gen.csv
+1 -1
View File
@@ -4,7 +4,7 @@ disableEnvelopeEncryption,GA,@grafana/grafana-as-code,false,false,false,false
live-service-web-worker,experimental,@grafana/grafana-app-platform-squad,false,false,false,true live-service-web-worker,experimental,@grafana/grafana-app-platform-squad,false,false,false,true
queryOverLive,experimental,@grafana/grafana-app-platform-squad,false,false,false,true queryOverLive,experimental,@grafana/grafana-app-platform-squad,false,false,false,true
panelTitleSearch,preview,@grafana/grafana-app-platform-squad,false,false,false,false panelTitleSearch,preview,@grafana/grafana-app-platform-squad,false,false,false,false
publicDashboards,preview,@grafana/sharing-squad,false,false,false,false publicDashboards,GA,@grafana/sharing-squad,false,false,false,false
publicDashboardsEmailSharing,preview,@grafana/sharing-squad,false,true,false,false publicDashboardsEmailSharing,preview,@grafana/sharing-squad,false,true,false,false
lokiExperimentalStreaming,experimental,@grafana/observability-logs,false,false,false,false lokiExperimentalStreaming,experimental,@grafana/observability-logs,false,false,false,false
featureHighlights,GA,@grafana/grafana-as-code,false,false,false,false featureHighlights,GA,@grafana/grafana-as-code,false,false,false,false
1 Name Stage Owner requiresDevMode RequiresLicense RequiresRestart FrontendOnly
4 live-service-web-worker experimental @grafana/grafana-app-platform-squad false false false true
5 queryOverLive experimental @grafana/grafana-app-platform-squad false false false true
6 panelTitleSearch preview @grafana/grafana-app-platform-squad false false false false
7 publicDashboards preview GA @grafana/sharing-squad false false false false
8 publicDashboardsEmailSharing preview @grafana/sharing-squad false true false false
9 lokiExperimentalStreaming experimental @grafana/observability-logs false false false false
10 featureHighlights GA @grafana/grafana-as-code false false false false
public/app/features/dashboard/components/ShareModal/SharePublicDashboard/CreatePublicDashboard/CreatePublicDashboard.tsx
+1 -1
View File
@@ -46,7 +46,7 @@ const CreatePublicDashboard = ({ isError }: { isError: boolean }) => {
return ( return (
<div className={styles.container}> <div className={styles.container}>
<div> <div>
<p className={styles.title}>Welcome to public dashboards public preview!</p> <p className={styles.title}>Welcome to public dashboards!</p>
<p className={styles.description}>Currently, we don’t support template variables or frontend data sources</p> <p className={styles.description}>Currently, we don’t support template variables or frontend data sources</p>
</div> </div>
public/app/features/dashboard/components/ShareModal/SharePublicDashboard/SharePublicDashboard.test.tsx
+1 -1
View File
@@ -195,7 +195,7 @@ describe('SharePublic - New config setup', () => {
it('renders when public dashboards feature is enabled', async () => { it('renders when public dashboards feature is enabled', async () => {
await renderSharePublicDashboard(); await renderSharePublicDashboard();
await screen.findByText('Welcome to public dashboards public preview!'); await screen.findByText('Welcome to public dashboards!');
expect(screen.getByText('Generate public URL')).toBeInTheDocument(); expect(screen.getByText('Generate public URL')).toBeInTheDocument();
expect(screen.queryByTestId(selectors.WillBePublicCheckbox)).toBeInTheDocument(); expect(screen.queryByTestId(selectors.WillBePublicCheckbox)).toBeInTheDocument();