From 4154a4066f5e3f2cc218b6f05849ab8b7436852a Mon Sep 17 00:00:00 2001 From: bergquist Date: Wed, 17 Aug 2016 22:12:08 +0200 Subject: [PATCH] feat(alerting): handle all results, even due they have errors DON'T SWALLOW THE ERR CARL --- pkg/services/alerting/engine.go | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/pkg/services/alerting/engine.go b/pkg/services/alerting/engine.go index e3813b8e912..7abfe32425c 100644 --- a/pkg/services/alerting/engine.go +++ b/pkg/services/alerting/engine.go @@ -101,11 +101,6 @@ func (e *Engine) resultDispatcher() { for result := range e.resultQueue { e.log.Debug("Alert Rule Result", "ruleId", result.Rule.Id, "firing", result.Firing) - - if result.Error != nil { - e.log.Error("Alert Rule Result Error", "ruleId", result.Rule.Id, "error", result.Error, "retry") - } else { - e.resultHandler.Handle(result) - } + e.resultHandler.Handle(result) } }