unified-storage: implement sqlkv Save method (#115458)

* unified-storage: sqlkv save method

pkg/storage/unified/sql/rvmanager/rv_manager.go

@@ -21,6 +21,19 @@ import (
 	"github.com/grafana/grafana/pkg/storage/unified/sql/sqltemplate"
 )
 
+type contextKey string
+
+const txKey contextKey = "rvmanager_db_tx"
+
+func ContextWithTx(ctx context.Context, tx db.Tx) context.Context {
+	return context.WithValue(ctx, txKey, tx)
+}
+
+func TxFromCtx(ctx context.Context) (db.Tx, bool) {
+	tx, ok := ctx.Value(txKey).(db.Tx)
+	return tx, ok
+}
+
 var tracer = otel.Tracer("github.com/grafana/grafana/pkg/storage/unified/sql/rvmanager")
 
 var (
@@ -294,7 +307,7 @@ func (m *ResourceVersionManager) execBatch(ctx context.Context, group, resource
 		// Allocate the RVs
 		for i, guid := range guids {
 			guidToRV[guid] = rv
-			guidToSnowflakeRV[guid] = snowflakeFromRv(rv)
+			guidToSnowflakeRV[guid] = SnowflakeFromRv(rv)
 			rvs[i] = rv
 			rv++
 		}
@@ -353,10 +366,20 @@ func (m *ResourceVersionManager) execBatch(ctx context.Context, group, resource
 
 // takes a unix microsecond rv and transforms into a snowflake format. The timestamp is converted from microsecond to
 // millisecond (the integer division) and the remainder is saved in the stepbits section. machine id is always 0
-func snowflakeFromRv(rv int64) int64 {
+func SnowflakeFromRv(rv int64) int64 {
 	return (((rv / 1000) - snowflake.Epoch) << (snowflake.NodeBits + snowflake.StepBits)) + (rv % 1000)
 }
 
+// helper utility to compare two RVs. The first RV must be in snowflake format. Will convert rv2 to snowflake and retry
+// if comparison fails
+func IsRvEqual(rv1, rv2 int64) bool {
+	if rv1 == rv2 {
+		return true
+	}
+
+	return rv1 == SnowflakeFromRv(rv2)
+}
+
 // Lock locks the resource version for the given key
 func (m *ResourceVersionManager) Lock(ctx context.Context, x db.ContextExecer, group, resource string) (nextRV int64, err error) {
 	// 1. Lock the row and prevent concurrent updates until the transaction is committed

pkg/storage/unified/sql/server.go

@@ -20,6 +20,8 @@ import (
 	"github.com/grafana/grafana/pkg/setting"
 	"github.com/grafana/grafana/pkg/storage/unified/resource"
 	"github.com/grafana/grafana/pkg/storage/unified/sql/db/dbimpl"
+	"github.com/grafana/grafana/pkg/storage/unified/sql/rvmanager"
+	"github.com/grafana/grafana/pkg/storage/unified/sql/sqltemplate"
 )
 
 type QOSEnqueueDequeuer interface {
@@ -103,11 +105,34 @@ func NewResourceServer(opts ServerOptions) (resource.ResourceServer, error) {
 				return nil, fmt.Errorf("error creating sqlkv: %s", err)
 			}
 
-			kvBackend, err := resource.NewKVStorageBackend(resource.KVBackendOptions{
+			kvBackendOpts := resource.KVBackendOptions{
 				KvStore: sqlkv,
 				Tracer:  opts.Tracer,
 				Reg:     opts.Reg,
+			}
+
+			ctx := context.Background()
+			dbConn, err := eDB.Init(ctx)
+			if err != nil {
+				return nil, fmt.Errorf("error initializing DB: %w", err)
+			}
+
+			dialect := sqltemplate.DialectForDriver(dbConn.DriverName())
+			if dialect == nil {
+				return nil, fmt.Errorf("unsupported database driver: %s", dbConn.DriverName())
+			}
+
+			rvManager, err := rvmanager.NewResourceVersionManager(rvmanager.ResourceManagerOptions{
+				Dialect: dialect,
+				DB:      dbConn,
 			})
+			if err != nil {
+				return nil, fmt.Errorf("failed to create resource version manager: %w", err)
+			}
+
+			// TODO add config to decide whether to pass RvManager or not
+			kvBackendOpts.RvManager = rvManager
+			kvBackend, err := resource.NewKVStorageBackend(kvBackendOpts)
 			if err != nil {
 				return nil, fmt.Errorf("error creating kv backend: %s", err)
 			}