From 4169646c8489a45584736b52de31ffd06b8d7109 Mon Sep 17 00:00:00 2001 From: Andrej Ocenas Date: Tue, 20 Oct 2020 17:41:47 +0200 Subject: [PATCH] Chore: Set timezone for tests to non utc. (#28405) * Set timezone for tests to non utc. * Fix comment --- jest.config.js | 5 ++++- packages/grafana-data/src/datetime/timezones.test.ts | 9 +++------ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/jest.config.js b/jest.config.js index 3d119641268..a32cf1443ab 100644 --- a/jest.config.js +++ b/jest.config.js @@ -1,4 +1,7 @@ -process.env.TZ = 'UTC'; +// We set this specifically for 2 reasons. +// 1. It makes sense for both CI tests and local tests to behave the same so issues are found earlier +// 2. Any wrong timezone handling could be hidden if we use UTC/GMT local time (which would happen in CI). +process.env.TZ = 'Pacific/Easter'; module.exports = { verbose: false, diff --git a/packages/grafana-data/src/datetime/timezones.test.ts b/packages/grafana-data/src/datetime/timezones.test.ts index 30f1b9d62fa..cd78b67940b 100644 --- a/packages/grafana-data/src/datetime/timezones.test.ts +++ b/packages/grafana-data/src/datetime/timezones.test.ts @@ -2,28 +2,25 @@ import { getTimeZoneInfo } from './timezones'; import { setTimeZoneResolver } from './common'; describe('getTimeZoneInfo', () => { - // global timezone is set to UTC, see jest-config.js file + // global timezone is set to Pacific/Easter, see jest-config.js file describe('IANA canonical name of the timezone', () => { it('should resolve for default timezone', () => { setTimeZoneResolver(() => 'browser'); const result = getTimeZoneInfo('', Date.now()); - expect(result?.ianaName).toBe('Africa/Abidjan'); + expect(result?.ianaName).toBe('Pacific/Easter'); }); it('should resolve for browser timezone', () => { - // global timezone is set to UTC const result = getTimeZoneInfo('browser', Date.now()); - expect(result?.ianaName).toBe('Africa/Abidjan'); + expect(result?.ianaName).toBe('Pacific/Easter'); }); it('should resolve for utc timezone', () => { - // global timezone is set to UTC const result = getTimeZoneInfo('utc', Date.now()); expect(result?.ianaName).toBe('UTC'); }); it('should resolve for given timezone', () => { - // global timezone is set to UTC const result = getTimeZoneInfo('Europe/Warsaw', Date.now()); expect(result?.ianaName).toBe('Europe/Warsaw'); });