K8s/FeatureFlags: Add an apiserver to manage feature flags (dev only) (#80501)

* add deployment registry API cloud only * update versions * add feature flag endpoints * use helpers * merge main * update AllowSelfServie and re-run code gen * fix package name * add allowselfserve flag to payload * remove config * update list api to return the full registry including states * change enabled check * fix compile error * add feature toggle and split path in frontend * changes * with status * add more status/state * add back config thing * add back config thing * merge main * merge main * now on the /current api endpoint * now on the /current api endpoint * drop frontend changes * change group name to featuretoggle (singular) * use the same settings * now with patch * more common refs * more common refs * WIP actually do the webhook * fix comment * fewer imports * registe standalone * one less file * fix singular name --------- Co-authored-by: Michael Mandrus <michael.mandrus@grafana.com>
2024-01-17 21:32:44 -08:00
parent cbc84a802d
commit 41e523bde7
25 changed files with 4058 additions and 120 deletions
@@ -0,0 +1,112 @@
+package featuretoggle
+
+import (
+	"context"
+	"encoding/json"
+	"net/http"
+
+	v1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+
+	common "github.com/grafana/grafana/pkg/apis/common/v0alpha1"
+	"github.com/grafana/grafana/pkg/apis/featuretoggle/v0alpha1"
+	"github.com/grafana/grafana/pkg/services/featuremgmt"
+	"github.com/grafana/grafana/pkg/web"
+)
+
+func getResolvedToggleState(ctx context.Context, features *featuremgmt.FeatureManager) v0alpha1.ResolvedToggleState {
+	state := v0alpha1.ResolvedToggleState{
+		TypeMeta: v1.TypeMeta{
+			APIVersion: v0alpha1.APIVERSION,
+			Kind:       "ResolvedToggleState",
+		},
+		Enabled: features.GetEnabled(ctx),
+	}
+
+	// Reference to the object that defined the values
+	startupRef := &common.ObjectReference{
+		Namespace: "system",
+		Name:      "startup",
+	}
+
+	startup := features.GetStartupFlags()
+	warnings := features.GetWarning()
+	for _, f := range features.GetFlags() {
+		name := f.Name
+		if features.IsHiddenFromAdminPage(name, true) {
+			continue
+		}
+
+		toggle := v0alpha1.ToggleStatus{
+			Name:        name,
+			Description: f.Description, // simplify the UI changes
+			Enabled:     state.Enabled[name],
+			Writeable:   features.IsEditableFromAdminPage(name),
+			Source:      startupRef,
+			Warning:     warnings[name],
+		}
+		if f.Expression == "true" && toggle.Enabled {
+			toggle.Source = nil
+		}
+		_, inStartup := startup[name]
+		if toggle.Enabled || toggle.Writeable || toggle.Warning != "" || inStartup {
+			state.Toggles = append(state.Toggles, toggle)
+		}
+	}
+	return state
+}
+
+func (b *FeatureFlagAPIBuilder) handleCurrentStatus(w http.ResponseWriter, r *http.Request) {
+	if r.Method == http.MethodPatch {
+		b.handlePatchCurrent(w, r)
+		return
+	}
+
+	state := getResolvedToggleState(r.Context(), b.features)
+
+	err := json.NewEncoder(w).Encode(state)
+	if err != nil {
+		w.WriteHeader(500)
+	}
+}
+
+// NOTE: authz is already handled by the authorizer
+func (b *FeatureFlagAPIBuilder) handlePatchCurrent(w http.ResponseWriter, r *http.Request) {
+	if !b.features.IsFeatureEditingAllowed() {
+		_, _ = w.Write([]byte("Feature editing is disabled"))
+		return
+	}
+
+	ctx := r.Context()
+	request := v0alpha1.ResolvedToggleState{}
+	err := web.Bind(r, &request)
+	if err != nil {
+		_, _ = w.Write([]byte("ERROR!!! " + err.Error()))
+		return
+	}
+
+	if len(request.Toggles) > 0 {
+		w.WriteHeader(http.StatusBadRequest)
+		_, _ = w.Write([]byte("can only patch the enabled"))
+		return
+	}
+
+	changes := map[string]bool{}
+	for k, v := range request.Enabled {
+		current := b.features.IsEnabled(ctx, k)
+		if current != v {
+			if !b.features.IsEditableFromAdminPage(k) {
+				w.WriteHeader(http.StatusBadRequest)
+				_, _ = w.Write([]byte("can not edit toggle: " + k))
+				return
+			}
+			changes[k] = v
+		}
+	}
+
+	if len(changes) == 0 {
+		w.WriteHeader(http.StatusNotModified)
+		return
+	}
+
+	_, _ = w.Write([]byte("TODO... actually UPDATE/call webhook: "))
+}