public/grafana
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Folders: Fix creating/updating a folder whose title has leading and trailing spaces (#80909)

Browse Source 
* Add tests

* Folders: Fix creating folder whose title has leading and trailing spaces

* Fix folder update

* Remove redundant argument

* Fix test
This commit is contained in:
Sofia Papagiannaki
2024-01-22 18:03:30 +02:00
committed by GitHub
parent e0402115ea
commit 4243079cb5
4 changed files with 97 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/services/folder/folderimpl/sqlstore_test.go
+8 -9
View File
@@ -11,7 +11,6 @@ import (
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"github.com/grafana/grafana/pkg/services/featuremgmt"
"github.com/grafana/grafana/pkg/services/folder"
"github.com/grafana/grafana/pkg/services/org"
"github.com/grafana/grafana/pkg/services/org/orgimpl"
@@ -29,7 +28,7 @@ func TestIntegrationCreate(t *testing.T) {
}
db := sqlstore.InitTestDB(t)
folderStore := ProvideStore(db, db.Cfg, featuremgmt.WithFeatures(featuremgmt.FlagNestedFolders))
folderStore := ProvideStore(db, db.Cfg)
orgID := CreateOrg(t, db)
@@ -149,7 +148,7 @@ func TestIntegrationDelete(t *testing.T) {
}
db := sqlstore.InitTestDB(t)
folderStore := ProvideStore(db, db.Cfg, featuremgmt.WithFeatures(featuremgmt.FlagNestedFolders))
folderStore := ProvideStore(db, db.Cfg)
orgID := CreateOrg(t, db)
@@ -196,7 +195,7 @@ func TestIntegrationUpdate(t *testing.T) {
}
db := sqlstore.InitTestDB(t)
folderStore := ProvideStore(db, db.Cfg, featuremgmt.WithFeatures(featuremgmt.FlagNestedFolders))
folderStore := ProvideStore(db, db.Cfg)
orgID := CreateOrg(t, db)
@@ -371,7 +370,7 @@ func TestIntegrationGet(t *testing.T) {
}
db := sqlstore.InitTestDB(t)
folderStore := ProvideStore(db, db.Cfg, featuremgmt.WithFeatures(featuremgmt.FlagNestedFolders))
folderStore := ProvideStore(db, db.Cfg)
orgID := CreateOrg(t, db)
@@ -450,7 +449,7 @@ func TestIntegrationGetParents(t *testing.T) {
}
db := sqlstore.InitTestDB(t)
folderStore := ProvideStore(db, db.Cfg, featuremgmt.WithFeatures(featuremgmt.FlagNestedFolders))
folderStore := ProvideStore(db, db.Cfg)
orgID := CreateOrg(t, db)
@@ -518,7 +517,7 @@ func TestIntegrationGetChildren(t *testing.T) {
}
db := sqlstore.InitTestDB(t)
folderStore := ProvideStore(db, db.Cfg, featuremgmt.WithFeatures(featuremgmt.FlagNestedFolders))
folderStore := ProvideStore(db, db.Cfg)
orgID := CreateOrg(t, db)
@@ -698,7 +697,7 @@ func TestIntegrationGetHeight(t *testing.T) {
}
db := sqlstore.InitTestDB(t)
folderStore := ProvideStore(db, db.Cfg, featuremgmt.WithFeatures(featuremgmt.FlagNestedFolders))
folderStore := ProvideStore(db, db.Cfg)
orgID := CreateOrg(t, db)
@@ -731,7 +730,7 @@ func TestIntegrationGetFolders(t *testing.T) {
foldersNum := 10
db := sqlstore.InitTestDB(t)
folderStore := ProvideStore(db, db.Cfg, featuremgmt.WithFeatures(featuremgmt.FlagNestedFolders))
folderStore := ProvideStore(db, db.Cfg)
orgID := CreateOrg(t, db)