public/grafana
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

GoogleCloudMonitoring: Refactor annotation code (#58417)

Browse Source
This commit is contained in:
Andres Martinez Gotor
2022-11-08 15:41:17 +01:00
committed by GitHub
parent 9281746914
commit 42b2e630b7
5 changed files with 33 additions and 102 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/tsdb/cloudmonitoring/annotation_query_test.go
+3 -6
View File
@@ -14,9 +14,8 @@ func TestExecutor_parseToAnnotations(t *testing.T) {
require.Len(t, d.TimeSeries, 3)
res := &backend.DataResponse{}
query := &cloudMonitoringTimeSeriesFilter{}
err = query.parseToAnnotations(res, d, "atitle {{metric.label.instance_name}} {{metric.value}}",
err = parseToAnnotations("anno", res, d, "atitle {{metric.label.instance_name}} {{metric.value}}",
"atext {{resource.label.zone}}")
require.NoError(t, err)
@@ -33,13 +32,12 @@ func TestExecutor_parseToAnnotations(t *testing.T) {
func TestCloudMonitoringExecutor_parseToAnnotations_emptyTimeSeries(t *testing.T) {
res := &backend.DataResponse{}
query := &cloudMonitoringTimeSeriesFilter{}
response := cloudMonitoringResponse{
TimeSeries: []timeSeries{},
}
err := query.parseToAnnotations(res, response, "atitle", "atext")
err := parseToAnnotations("anno", res, response, "atitle", "atext")
require.NoError(t, err)
require.Len(t, res.Frames, 1)
@@ -55,7 +53,6 @@ func TestCloudMonitoringExecutor_parseToAnnotations_emptyTimeSeries(t *testing.T
func TestCloudMonitoringExecutor_parseToAnnotations_noPointsInSeries(t *testing.T) {
res := &backend.DataResponse{}
query := &cloudMonitoringTimeSeriesFilter{}
response := cloudMonitoringResponse{
TimeSeries: []timeSeries{
@@ -63,7 +60,7 @@ func TestCloudMonitoringExecutor_parseToAnnotations_noPointsInSeries(t *testing.
},
}
err := query.parseToAnnotations(res, response, "atitle", "atext")
err := parseToAnnotations("anno", res, response, "atitle", "atext")
require.NoError(t, err)
require.Len(t, res.Frames, 1)