From 4319a934e90be864c3301280f9471194658c45e3 Mon Sep 17 00:00:00 2001 From: "Grot (@grafanabot)" <43478413+grafanabot@users.noreply.github.com> Date: Wed, 24 Nov 2021 05:08:35 -0500 Subject: [PATCH] Tracing: Show start time of trace with milliseconds precision (#42132) (#42138) * Tracing header: Add setting to show start time with ms * Add test * Update test (cherry picked from commit aefb2659ecd1e7c684c98bafbb64da81d9905d06) Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com> --- .../src/TracePageHeader/TracePageHeader.test.js | 5 +++++ .../src/TracePageHeader/TracePageHeader.tsx | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/packages/jaeger-ui-components/src/TracePageHeader/TracePageHeader.test.js b/packages/jaeger-ui-components/src/TracePageHeader/TracePageHeader.test.js index d4ba4132d82..e455fa1f360 100644 --- a/packages/jaeger-ui-components/src/TracePageHeader/TracePageHeader.test.js +++ b/packages/jaeger-ui-components/src/TracePageHeader/TracePageHeader.test.js @@ -60,6 +60,11 @@ describe('', () => { }); }); + it('renders start time in header with millisecond precision', () => { + const startTimeMs = wrapper.find(LabeledList).props().items[0].value.props.children[1].props.children; + expect(startTimeMs).toMatch(/:\d\d\.\d\d\d/g); + }); + it('renders a ', () => { expect(wrapper.find(SpanGraph).length).toBe(1); }); diff --git a/packages/jaeger-ui-components/src/TracePageHeader/TracePageHeader.tsx b/packages/jaeger-ui-components/src/TracePageHeader/TracePageHeader.tsx index f1c69988e20..1e39a259fad 100644 --- a/packages/jaeger-ui-components/src/TracePageHeader/TracePageHeader.tsx +++ b/packages/jaeger-ui-components/src/TracePageHeader/TracePageHeader.tsx @@ -167,7 +167,7 @@ export const HEADER_ITEMS = [ label: 'Trace Start', renderer(trace: Trace, timeZone: TimeZone, styles: ReturnType) { // Convert date from micro to milli seconds - const dateStr = dateTimeFormat(trace.startTime / 1000, { timeZone }); + const dateStr = dateTimeFormat(trace.startTime / 1000, { timeZone, defaultWithMS: true }); const match = dateStr.match(/^(.+)(:\d\d\.\d+)$/); return match ? (