From 4386085aa9a1f7c3c2b723835ea63815a66169c5 Mon Sep 17 00:00:00 2001 From: Stephanie Hingtgen Date: Mon, 30 Jun 2025 18:11:27 -0600 Subject: [PATCH] fix linter --- pkg/registry/apis/provisioning/resources/dualwriter.go | 6 +++--- pkg/tests/apis/provisioning/provisioning_test.go | 3 +-- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/pkg/registry/apis/provisioning/resources/dualwriter.go b/pkg/registry/apis/provisioning/resources/dualwriter.go index d35c66b4f16..3a9f5a05570 100644 --- a/pkg/registry/apis/provisioning/resources/dualwriter.go +++ b/pkg/registry/apis/provisioning/resources/dualwriter.go @@ -418,8 +418,8 @@ func (r *DualReadWriter) getChildren(ctx context.Context, folderPath string, tre } } - var parsedResources []*ParsedResource - for _, entry := range resourcesInFolder { + parsedResources := make([]*ParsedResource, len(resourcesInFolder)) + for i, entry := range resourcesInFolder { fileInfo, err := r.repo.Read(ctx, entry.Path, "") if err != nil && !apierrors.IsNotFound(err) { return nil, nil, fmt.Errorf("could not find resource in repository: %w", err) @@ -430,7 +430,7 @@ func (r *DualReadWriter) getChildren(ctx context.Context, folderPath string, tre return nil, nil, fmt.Errorf("could not parse resource: %w", err) } - parsedResources = append(parsedResources, parsed) + parsedResources[i] = parsed } return parsedResources, foldersInFolder, nil diff --git a/pkg/tests/apis/provisioning/provisioning_test.go b/pkg/tests/apis/provisioning/provisioning_test.go index b00501bdd2b..db5eeb2ce2b 100644 --- a/pkg/tests/apis/provisioning/provisioning_test.go +++ b/pkg/tests/apis/provisioning/provisioning_test.go @@ -707,8 +707,6 @@ func TestIntegrationProvisioning_DeleteResources(t *testing.T) { Do(ctx) require.NoError(t, result.Error()) - helper.SyncAndWait(t, repo, nil) - dashboards, err := helper.DashboardsV1.Resource.List(ctx, metav1.ListOptions{}) require.NoError(t, err) require.Equal(t, 3, len(dashboards.Items)) @@ -741,6 +739,7 @@ func TestIntegrationProvisioning_DeleteResources(t *testing.T) { require.NoError(t, err) resp, err := http.DefaultClient.Do(req) require.NoError(t, err) + // nolint:errcheck defer resp.Body.Close() require.Equal(t, http.StatusOK, resp.StatusCode)