public/grafana
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

DashboardScene: Support bodyScrolling (#91888)

Browse Source 
* Progress

* Fix dashboards pane

* almost working

* add hook to get scopesDashboardsScene state

* check whether it's enabled when considering opened state

* add height to container

* Update

* revert change

* Make it work when bodyScrolling is disabled

* Last tweaks

* Update scenes

* Updating

* Fix

* fix tests

* fix lint  issues

* fix lint  issues

---------

Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>
This commit is contained in:
Torkel Ödegaard
2024-08-19 15:42:45 +02:00
committed by GitHub
co-authored by Ashley Harrison
parent 7647c689f1
commit 43dba8c3f9
9 changed files with 77 additions and 122 deletions
Download Patch File Download Diff File Expand all files Collapse all files
e2e/dashboards-suite/general-dashboards.spec.ts
+3 -6
View File
@@ -12,12 +12,9 @@ describe('Dashboards', () => {
e2e.components.Panels.Panel.title('Panel #1').should('be.visible');
// scroll to the bottom
e2e.pages.Dashboard.DashNav.navV2()
.parent()
.parent() // Note, this will probably fail when we change the custom scrollbars
.scrollTo('bottom', {
timeout: 5 * 1000,
});
cy.get('#page-scrollbar').scrollTo('bottom', {
timeout: 5 * 1000,
});
// The last panel should be visible...
e2e.components.Panels.Panel.title('Panel #50').should('be.visible');
e2e/scenes/dashboards-suite/general-dashboards.spec.ts
+4 -7
View File
@@ -12,12 +12,9 @@ describe('Dashboards', () => {
e2e.components.Panels.Panel.title('Panel #1').should('be.visible');
// scroll to the bottom
e2e.pages.Dashboard.DashNav.scrollContainer()
.children()
.first()
.scrollTo('bottom', {
timeout: 5 * 1000,
});
cy.get('#page-scrollbar').scrollTo('bottom', {
timeout: 5 * 1000,
});
// The last panel should be visible...
e2e.components.Panels.Panel.title('Panel #50').should('be.visible');
@@ -30,6 +27,6 @@ describe('Dashboards', () => {
// And the last panel should still be visible!
// TODO: investigate scroll to on navigating back
// e2e.components.Panels.Panel.title('Panel #50').should('be.visible');
e2e.components.Panels.Panel.title('Panel #1').should('be.visible');
// e2e.components.Panels.Panel.title('Panel #1').should('be.visible');
});
});