Auth: Improve /admin/authentication permission checks and include new SSO pages (#81183)

* Move evalAuthSettings to ssoutils

* Improve permission check for auth page
This commit is contained in:
Misi
2024-01-25 11:13:24 +01:00
committed by GitHub
parent 7e5544ab21
commit 4577e61ee7
4 changed files with 38 additions and 17 deletions
@@ -0,0 +1,24 @@
package ssoutils
import (
ac "github.com/grafana/grafana/pkg/services/accesscontrol"
"github.com/grafana/grafana/pkg/setting"
)
func EvalAuthenticationSettings(cfg *setting.Cfg) ac.Evaluator {
return ac.EvalAny(
ac.EvalAll(
ac.EvalPermission(ac.ActionSettingsWrite, ac.ScopeSettingsSAML),
ac.EvalPermission(ac.ActionSettingsRead, ac.ScopeSettingsSAML),
),
ac.EvalPermission(ac.ActionLDAPStatusRead))
}
func OauthSettingsEvaluator(cfg *setting.Cfg) ac.Evaluator {
result := make([]ac.Evaluator, 0, len(cfg.SSOSettingsConfigurableProviders))
for provider := range cfg.SSOSettingsConfigurableProviders {
result = append(result, ac.EvalPermission(ac.ActionSettingsRead, ac.ScopeSettingsOAuth(provider)))
result = append(result, ac.EvalPermission(ac.ActionSettingsWrite, ac.ScopeSettingsOAuth(provider)))
}
return ac.EvalAny(result...)
}