public/grafana
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Sql Expressions: (Chore) Dedicated logger for expr.sql, and pass context (#109549)

Browse Source
This commit is contained in:
Kyle Brandt
2025-08-13 11:20:14 -04:00
committed by GitHub
parent 789a61230d
commit 466aa70179
17 changed files with 56 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/expr/service_sql_test.go
+4 -4
View File
@@ -56,14 +56,14 @@ func TestSQLService(t *testing.T) {
t.Run("no feature flag no queries for you", func(t *testing.T) {
s, req := newMockQueryService(resp, newABSQLQueries(""))
_, err := s.BuildPipeline(req)
_, err := s.BuildPipeline(t.Context(), req)
require.Error(t, err, "should not be able to build pipeline without feature flag")
})
t.Run("with feature flag basic select works", func(t *testing.T) {
s, req := newMockQueryService(resp, newABSQLQueries("SELECT * FROM A"))
s.features = featuremgmt.WithFeatures(featuremgmt.FlagSqlExpressions)
pl, err := s.BuildPipeline(req)
pl, err := s.BuildPipeline(t.Context(), req)
require.NoError(t, err)
res, err := s.ExecutePipeline(context.Background(), time.Now(), pl)
@@ -83,7 +83,7 @@ func TestSQLService(t *testing.T) {
s.features = featuremgmt.WithFeatures(featuremgmt.FlagSqlExpressions)
pl, err := s.BuildPipeline(req)
pl, err := s.BuildPipeline(t.Context(), req)
require.NoError(t, err)
rsp, err := s.ExecutePipeline(context.Background(), time.Now(), pl)
@@ -100,7 +100,7 @@ func TestSQLService(t *testing.T) {
s.features = featuremgmt.WithFeatures(featuremgmt.FlagSqlExpressions)
pl, err := s.BuildPipeline(req)
pl, err := s.BuildPipeline(t.Context(), req)
require.NoError(t, err)
rsp, err := s.ExecutePipeline(context.Background(), time.Now(), pl)