diff --git a/public/app/features/search/page/components/ConfirmDeleteModal.test.tsx b/public/app/features/search/page/components/ConfirmDeleteModal.test.tsx index c9e34903120..2c0192cbb70 100644 --- a/public/app/features/search/page/components/ConfirmDeleteModal.test.tsx +++ b/public/app/features/search/page/components/ConfirmDeleteModal.test.tsx @@ -10,16 +10,8 @@ describe('ConfirmModal', () => { dashboardsUIDs.add('uid1'); dashboardsUIDs.add('uid2'); items.set('dashboard', dashboardsUIDs); - const isDeleteModalOpen = true; const onDeleteItems = jest.fn(); - render( - {}} - /> - ); + render( {}} />); expect(screen.getByRole('heading', { name: 'Delete' })).toBeInTheDocument(); expect(screen.getByText('Do you want to delete the 2 selected dashboards?')).toBeInTheDocument(); diff --git a/public/app/features/search/page/components/ConfirmDeleteModal.tsx b/public/app/features/search/page/components/ConfirmDeleteModal.tsx index 15f5c4a7bec..f5c6e5bdcf7 100644 --- a/public/app/features/search/page/components/ConfirmDeleteModal.tsx +++ b/public/app/features/search/page/components/ConfirmDeleteModal.tsx @@ -10,11 +10,10 @@ import { OnMoveOrDeleleSelectedItems } from '../../types'; interface Props { onDeleteItems: OnMoveOrDeleleSelectedItems; results: Map>; - isOpen: boolean; onDismiss: () => void; } -export const ConfirmDeleteModal = ({ results, onDeleteItems, isOpen, onDismiss }: Props) => { +export const ConfirmDeleteModal = ({ results, onDeleteItems, onDismiss }: Props) => { const styles = useStyles2(getStyles); const dashboards = Array.from(results.get('dashboard') ?? []); @@ -44,9 +43,9 @@ export const ConfirmDeleteModal = ({ results, onDeleteItems, isOpen, onDismiss } }); }; - return isOpen ? ( + return ( @@ -57,7 +56,7 @@ export const ConfirmDeleteModal = ({ results, onDeleteItems, isOpen, onDismiss } onConfirm={deleteItems} onDismiss={onDismiss} /> - ) : null; + ); }; const getStyles = (theme: GrafanaTheme2) => ({ diff --git a/public/app/features/search/page/components/ManageActions.tsx b/public/app/features/search/page/components/ManageActions.tsx index fa250bd4bb4..dd8dbe90a2c 100644 --- a/public/app/features/search/page/components/ManageActions.tsx +++ b/public/app/features/search/page/components/ManageActions.tsx @@ -55,18 +55,13 @@ export function ManageActions({ items, folder, onChange, clearSelection }: Props - setIsDeleteModalOpen(false)} - /> - setIsMoveModalOpen(false)} - /> + {isDeleteModalOpen && ( + setIsDeleteModalOpen(false)} /> + )} + + {isMoveModalOpen && ( + setIsMoveModalOpen(false)} /> + )} ); } diff --git a/public/app/features/search/page/components/MoveToFolderModal.test.tsx b/public/app/features/search/page/components/MoveToFolderModal.test.tsx index 909bec998ff..230777e79f5 100644 --- a/public/app/features/search/page/components/MoveToFolderModal.test.tsx +++ b/public/app/features/search/page/components/MoveToFolderModal.test.tsx @@ -18,14 +18,13 @@ describe('MoveToFolderModal', () => { dashboardsUIDs.add('uid1'); dashboardsUIDs.add('uid2'); items.set('dashboard', dashboardsUIDs); - const isMoveModalOpen = true; const mockStore = configureMockStore(); const store = mockStore({ dashboard: { panels: [] } }); const onMoveItems = jest.fn(); render( - {}} /> + {}} /> ); diff --git a/public/app/features/search/page/components/MoveToFolderModal.tsx b/public/app/features/search/page/components/MoveToFolderModal.tsx index 0808bc62a5d..24a3abef1e4 100644 --- a/public/app/features/search/page/components/MoveToFolderModal.tsx +++ b/public/app/features/search/page/components/MoveToFolderModal.tsx @@ -13,11 +13,10 @@ import { OnMoveOrDeleleSelectedItems } from '../../types'; interface Props { onMoveItems: OnMoveOrDeleleSelectedItems; results: Map>; - isOpen: boolean; onDismiss: () => void; } -export const MoveToFolderModal = ({ results, onMoveItems, isOpen, onDismiss }: Props) => { +export const MoveToFolderModal = ({ results, onMoveItems, onDismiss }: Props) => { const [folder, setFolder] = useState(null); const styles = useStyles2(getStyles); const notifyApp = useAppNotification(); @@ -49,25 +48,19 @@ export const MoveToFolderModal = ({ results, onMoveItems, isOpen, onDismiss }: P } }; - return isOpen ? ( - + return ( + <>

Move the {selectedDashboards.length} selected dashboard{selectedDashboards.length === 1 ? '' : 's'} to the following folder:

- setFolder(f)} /> + setFolder(f)} />
-