From 48fe92a9457210a5a9551a8cd5b22d82a880ec11 Mon Sep 17 00:00:00 2001 From: Victor Cinaglia Date: Tue, 18 Dec 2018 08:32:49 -0500 Subject: [PATCH] snapshots: Close response body after error check --- pkg/api/dashboard_snapshot.go | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/pkg/api/dashboard_snapshot.go b/pkg/api/dashboard_snapshot.go index af818be99b0..ca7e78a58cd 100644 --- a/pkg/api/dashboard_snapshot.go +++ b/pkg/api/dashboard_snapshot.go @@ -51,13 +51,10 @@ func createExternalDashboardSnapshot(cmd m.CreateDashboardSnapshotCommand) (*Cre } response, err := client.Post(setting.ExternalSnapshotUrl+"/api/snapshots", "application/json", bytes.NewBuffer(messageBytes)) - if response != nil { - defer response.Body.Close() - } - if err != nil { return nil, err } + defer response.Body.Close() if response.StatusCode != 200 { return nil, fmt.Errorf("Create external snapshot response status code %d", response.StatusCode) @@ -159,14 +156,10 @@ func GetDashboardSnapshot(c *m.ReqContext) { func deleteExternalDashboardSnapshot(externalUrl string) error { response, err := client.Get(externalUrl) - - if response != nil { - defer response.Body.Close() - } - if err != nil { return err } + defer response.Body.Close() if response.StatusCode == 200 { return nil