From 49032ae3d7a55a62563fcfcc6d45bb69b82b2159 Mon Sep 17 00:00:00 2001
From: Adela Almasan <88068998+adela-almasan@users.noreply.github.com>
Date: Fri, 19 Dec 2025 11:23:27 -0600
Subject: [PATCH] VizSuggestions: Update selected suggestion styling (#115581)

* update selected suggestion style

* update highlight styles for light theme, add inert to div

* remove commented-out original idea

---------

Co-authored-by: Paul Marbach <paul.marbach@grafana.com>
---
 .../VisualizationSuggestionCard.tsx           | 39 +++++++++----------
 1 file changed, 18 insertions(+), 21 deletions(-)

diff --git a/public/app/features/panel/components/VizTypePicker/VisualizationSuggestionCard.tsx b/public/app/features/panel/components/VizTypePicker/VisualizationSuggestionCard.tsx
index 7248dbcc1e5..632c143fe3a 100644
--- a/public/app/features/panel/components/VizTypePicker/VisualizationSuggestionCard.tsx
+++ b/public/app/features/panel/components/VizTypePicker/VisualizationSuggestionCard.tsx
@@ -2,7 +2,7 @@ import { css, cx } from '@emotion/css';
 import { cloneDeep } from 'lodash';
 import { CSSProperties, HTMLAttributes, ReactNode } from 'react';
 
-import { colorManipulator, GrafanaTheme2, PanelData, PanelPluginVisualizationSuggestion } from '@grafana/data';
+import { GrafanaTheme2, PanelData, PanelPluginVisualizationSuggestion } from '@grafana/data';
 import { selectors } from '@grafana/e2e-selectors';
 import { config } from '@grafana/runtime';
 import { Tooltip, useStyles2 } from '@grafana/ui';
@@ -31,7 +31,11 @@ export function VisualizationSuggestionCard({
 
   const commonButtonProps = {
     'aria-label': suggestion.name,
-    className: cx(className, styles.vizBox),
+    className: cx(
+      className,
+      styles.vizBox,
+      config.featureToggles.newVizSuggestions && isSelected && styles.selectedBox
+    ),
     'data-testid': selectors.components.VisualizationPreview.card(suggestion.name),
     style: outerStyles,
     tabIndex: -1, // selection is handled by parent container
@@ -56,7 +60,12 @@ export function VisualizationSuggestionCard({
 
     content = (
       <button {...commonButtonProps}>
-        <div style={innerStyles} className={styles.renderContainer}>
+        {/* to use inert in React 18, we have to do this hacky object spread thing. https://stackoverflow.com/questions/72720469/error-when-using-inert-attribute-with-typescript */}
+        <div
+          style={innerStyles}
+          className={cx(styles.renderContainer, isSelected && styles.selectedSuggestion)}
+          {...{ inert: '' }}
+        >
           <PanelRenderer
             title=""
             data={data}
@@ -66,8 +75,6 @@ export function VisualizationSuggestionCard({
             options={preview.options}
             fieldConfig={preview.fieldConfig}
           />
-          {/* this prevents interaction with the underlying panel. */}
-          <div className={cx(styles.hoverPane, isSelected && styles.hoverPaneSelected)} />
         </div>
       </button>
     );
@@ -82,22 +89,8 @@ export function VisualizationSuggestionCard({
 
 const getStyles = (theme: GrafanaTheme2) => {
   return {
-    hoverPane: css({
-      position: 'absolute',
-      top: -4,
-      left: -4,
-      right: -2,
-      bottom: -2,
-      borderRadius: theme.spacing(0.5),
-      background: 'transparent',
-      [theme.transitions.handleMotion('no-preference', 'reduce')]: {
-        transition: theme.transitions.create(['background'], {
-          duration: theme.transitions.duration.short,
-        }),
-      },
-    }),
-    hoverPaneSelected: css({
-      background: colorManipulator.alpha(theme.colors.text.primary, 0.1),
+    selectedSuggestion: css({
+      filter: `blur(1px) ${theme.isDark ? 'brightness(0.5)' : 'opacity(0.3)'}`,
     }),
     vizBox: css({
       position: 'relative',
@@ -149,6 +142,10 @@ const getStyles = (theme: GrafanaTheme2) => {
       top: '6px',
       left: '6px',
     }),
+    selectedBox: css({
+      border: `1px solid ${theme.colors.primary.border}`,
+      background: theme.colors.action.selected,
+    }),
   };
 };