RBAC: Remove legacy ac from authorization middleware (#68898)

remove legacy AC fallback from RBAC middleware, and some unused auth logic

pkg/services/accesscontrol/middleware_test.go

@@ -18,7 +18,6 @@ import (
 
 type middlewareTestCase struct {
 	desc           string
-	expectFallback bool
 	expectEndpoint bool
 	evaluator      accesscontrol.Evaluator
 	ac             accesscontrol.AccessControl
@@ -26,19 +25,12 @@ type middlewareTestCase struct {
 
 func TestMiddleware(t *testing.T) {
 	tests := []middlewareTestCase{
-		{
-			desc:           "should use fallback if access control is disabled",
-			ac:             mock.New().WithDisabled(),
-			expectFallback: true,
-			expectEndpoint: true,
-		},
 		{
 			desc: "should pass middleware for correct permissions",
 			ac: mock.New().WithPermissions(
 				[]accesscontrol.Permission{{Action: "users:read", Scope: "users:*"}},
 			),
 			evaluator:      accesscontrol.EvalPermission("users:read", "users:*"),
-			expectFallback: false,
 			expectEndpoint: true,
 		},
 		{
@@ -47,23 +39,17 @@ func TestMiddleware(t *testing.T) {
 				[]accesscontrol.Permission{{Action: "users:read", Scope: "users:1"}},
 			),
 			evaluator:      accesscontrol.EvalPermission("users:read", "users:*"),
-			expectFallback: false,
 			expectEndpoint: false,
 		},
 	}
 
 	for _, test := range tests {
 		t.Run(test.desc, func(t *testing.T) {
-			fallbackCalled := false
-			fallback := func(c *contextmodel.ReqContext) {
-				fallbackCalled = true
-			}
-
 			server := web.New()
 			server.UseMiddleware(web.Renderer("../../public/views", "[[", "]]"))
 
 			server.Use(contextProvider())
-			server.Use(accesscontrol.Middleware(test.ac)(fallback, test.evaluator))
+			server.Use(accesscontrol.Middleware(test.ac)(test.evaluator))
 
 			endpointCalled := false
 			server.Get("/", func(c *contextmodel.ReqContext) {
@@ -77,7 +63,6 @@ func TestMiddleware(t *testing.T) {
 
 			server.ServeHTTP(recorder, request)
 
-			assert.Equal(t, test.expectFallback, fallbackCalled)
 			assert.Equal(t, test.expectEndpoint, endpointCalled)
 		})
 	}
@@ -111,7 +96,7 @@ func TestMiddleware_forceLogin(t *testing.T) {
 			c.IsSignedIn = false
 		}))
 		server.Use(
-			accesscontrol.Middleware(ac)(nil, accesscontrol.EvalPermission("endpoint:read", "endpoint:1")),
+			accesscontrol.Middleware(ac)(accesscontrol.EvalPermission("endpoint:read", "endpoint:1")),
 		)
 
 		request, err := http.NewRequest(http.MethodGet, tc.url, nil)