AzureMonitor: Refactor Log Analytics backend (#87429)

* Remove unneeded error check * Refactor to reduce cyclomatic complexity * Add util function for parsing resultformat * Make use of util * Remove unneeded types * Move types to their own file * Move getApiUrl to utils * Move traces functions to separate file - Add separate helper for building trace string queries * Add helper for determining resources * Add test for RetrieveResources * Don't append twice * Refactor tests
2024-05-10 17:11:54 +01:00
parent 95667f6a53
commit 49e6bf26b3
8 changed files with 1824 additions and 1598 deletions
@@ -0,0 +1,101 @@
+package loganalytics
+
+import (
+	"testing"
+
+	"github.com/grafana/grafana/pkg/tsdb/azuremonitor/kinds/dataquery"
+	"github.com/stretchr/testify/assert"
+)
+
+func TestParseResultFormat(t *testing.T) {
+	emptyResultFormat := dataquery.ResultFormat("")
+	traceFormat := dataquery.ResultFormatTrace
+	testCases := []struct {
+		name                 string
+		queryResultFormat    *dataquery.ResultFormat
+		queryType            dataquery.AzureQueryType
+		expectedResultFormat dataquery.ResultFormat
+	}{
+		{
+			name:                 "returns the logs format as default for logs queries if input format is nil",
+			queryResultFormat:    nil,
+			queryType:            dataquery.AzureQueryTypeAzureLogAnalytics,
+			expectedResultFormat: dataquery.ResultFormatLogs,
+		},
+		{
+			name:                 "returns the table format as default for traces queries if input format is nil",
+			queryResultFormat:    nil,
+			queryType:            dataquery.AzureQueryTypeAzureTraces,
+			expectedResultFormat: dataquery.ResultFormatTable,
+		},
+		{
+			name:                 "returns the logs format as default for logs queries if input format is empty",
+			queryResultFormat:    &emptyResultFormat,
+			queryType:            dataquery.AzureQueryTypeAzureLogAnalytics,
+			expectedResultFormat: dataquery.ResultFormatLogs,
+		},
+		{
+			name:                 "returns the table format as default for traces queries if input format is empty",
+			queryResultFormat:    &emptyResultFormat,
+			queryType:            dataquery.AzureQueryTypeAzureTraces,
+			expectedResultFormat: dataquery.ResultFormatTable,
+		},
+		{
+			name:                 "returns the query result format",
+			queryResultFormat:    &traceFormat,
+			queryType:            dataquery.AzureQueryTypeAzureTraces,
+			expectedResultFormat: dataquery.ResultFormatTrace,
+		},
+	}
+
+	for _, tc := range testCases {
+		t.Run(tc.name, func(t *testing.T) {
+			rf := ParseResultFormat(tc.queryResultFormat, tc.queryType)
+			assert.Equal(t, tc.expectedResultFormat, rf)
+		})
+	}
+}
+
+func TestRetrieveResources(t *testing.T) {
+	legacyResource := "test-single-resource"
+	legacyWorkspace := "test-workspace"
+	testCases := []struct {
+		name                        string
+		query                       dataquery.AzureLogsQuery
+		expectedResources           []string
+		expectedResourceOrWorkspace string
+	}{
+		{
+			name: "current resource query returns the resources and the first resource",
+			query: dataquery.AzureLogsQuery{
+				Resources: []string{"test-resource"},
+			},
+			expectedResources:           []string{"test-resource"},
+			expectedResourceOrWorkspace: "test-resource",
+		},
+		{
+			name: "legacy query with resource specified",
+			query: dataquery.AzureLogsQuery{
+				Resource: &legacyResource,
+			},
+			expectedResources:           []string{"test-single-resource"},
+			expectedResourceOrWorkspace: "test-single-resource",
+		},
+		{
+			name: "legacy query with workspace specified",
+			query: dataquery.AzureLogsQuery{
+				Workspace: &legacyWorkspace,
+			},
+			expectedResources:           []string{},
+			expectedResourceOrWorkspace: "test-workspace",
+		},
+	}
+
+	for _, tc := range testCases {
+		t.Run(tc.name, func(t *testing.T) {
+			resources, resourceOrWorkspace := retrieveResources(tc.query)
+			assert.Equal(t, tc.expectedResources, resources)
+			assert.Equal(t, tc.expectedResourceOrWorkspace, resourceOrWorkspace)
+		})
+	}
+}