From 4a116ad4ad9aa1e34e7706867a2c94e317f703df Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Torkel=20=C3=96degaard?= Date: Sat, 1 Oct 2016 17:36:56 +0200 Subject: [PATCH] fix(build): fixed failing unit test --- pkg/services/sqlstore/datasource.go | 3 +-- pkg/services/sqlstore/datasource_test.go | 9 +++++++-- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/pkg/services/sqlstore/datasource.go b/pkg/services/sqlstore/datasource.go index 56ca4f859e9..0e6219785bd 100644 --- a/pkg/services/sqlstore/datasource.go +++ b/pkg/services/sqlstore/datasource.go @@ -60,9 +60,8 @@ func DeleteDataSource(cmd *m.DeleteDataSourceCommand) error { func AddDataSource(cmd *m.AddDataSourceCommand) error { return inTransaction(func(sess *xorm.Session) error { - existing := m.DataSource{OrgId: cmd.OrgId, Name: cmd.Name} - has, _ := x.Get(&existing) + has, _ := sess.Get(&existing) if has { return m.ErrDataSourceNameExists diff --git a/pkg/services/sqlstore/datasource_test.go b/pkg/services/sqlstore/datasource_test.go index b14c7ed9a24..35752eeaafc 100644 --- a/pkg/services/sqlstore/datasource_test.go +++ b/pkg/services/sqlstore/datasource_test.go @@ -41,6 +41,7 @@ func TestDataAccess(t *testing.T) { err := AddDataSource(&m.AddDataSourceCommand{ OrgId: 10, + Name: "laban", Type: m.DS_INFLUXDB, Access: m.DS_ACCESS_DIRECT, Url: "http://test", @@ -63,15 +64,19 @@ func TestDataAccess(t *testing.T) { Convey("Given a datasource", func() { - AddDataSource(&m.AddDataSourceCommand{ + err := AddDataSource(&m.AddDataSourceCommand{ OrgId: 10, + Name: "nisse", Type: m.DS_GRAPHITE, Access: m.DS_ACCESS_DIRECT, Url: "http://test", }) + So(err, ShouldBeNil) query := m.GetDataSourcesQuery{OrgId: 10} - GetDataSources(&query) + err = GetDataSources(&query) + So(err, ShouldBeNil) + ds := query.Result[0] Convey("Can delete datasource", func() {