From 4a1ca7e32fbe870165ec47def2436c55597c7e92 Mon Sep 17 00:00:00 2001 From: George Robinson Date: Mon, 19 Sep 2022 10:42:04 +0100 Subject: [PATCH] Alerting: Change default alert state to Error on execution error or timeout (#55345) --- public/app/features/alerting/unified/RuleEditor.test.tsx | 6 +++--- public/app/features/alerting/unified/utils/rule-form.ts | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/public/app/features/alerting/unified/RuleEditor.test.tsx b/public/app/features/alerting/unified/RuleEditor.test.tsx index 140eeff15d8..a8d856b3a2e 100644 --- a/public/app/features/alerting/unified/RuleEditor.test.tsx +++ b/public/app/features/alerting/unified/RuleEditor.test.tsx @@ -294,7 +294,7 @@ describe('RuleEditor', () => { grafana_alert: { condition: 'B', data: getDefaultQueries(), - exec_err_state: 'Alerting', + exec_err_state: 'Error', no_data_state: 'NoData', title: 'my great new rule', }, @@ -447,7 +447,7 @@ describe('RuleEditor', () => { namespace_id: 1, condition: 'B', data: getDefaultQueries(), - exec_err_state: GrafanaAlertStateDecision.Alerting, + exec_err_state: GrafanaAlertStateDecision.Error, no_data_state: GrafanaAlertStateDecision.NoData, title: 'my great new rule', }, @@ -505,7 +505,7 @@ describe('RuleEditor', () => { uid, condition: 'B', data: getDefaultQueries(), - exec_err_state: 'Alerting', + exec_err_state: 'Error', no_data_state: 'NoData', title: 'my great new rule', }, diff --git a/public/app/features/alerting/unified/utils/rule-form.ts b/public/app/features/alerting/unified/utils/rule-form.ts index 321216323da..cdd336af723 100644 --- a/public/app/features/alerting/unified/utils/rule-form.ts +++ b/public/app/features/alerting/unified/utils/rule-form.ts @@ -56,7 +56,7 @@ export const getDefaultFormValues = (): RuleFormValues => { queries: [], condition: '', noDataState: GrafanaAlertStateDecision.NoData, - execErrState: GrafanaAlertStateDecision.Alerting, + execErrState: GrafanaAlertStateDecision.Error, evaluateEvery: '1m', evaluateFor: '5m',