From 4a71a79cb88f5be7a353bc5cb3f8294a3036e0d6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Torkel=20=C3=96degaard?= Date: Wed, 27 May 2015 10:42:52 +0200 Subject: [PATCH] Slight refactoring in annotationSrv --- .../features/annotations/annotationsSrv.js | 34 ++++++++----------- 1 file changed, 14 insertions(+), 20 deletions(-) diff --git a/public/app/features/annotations/annotationsSrv.js b/public/app/features/annotations/annotationsSrv.js index af86a7dfe6d..0ba30f1ef8b 100644 --- a/public/app/features/annotations/annotationsSrv.js +++ b/public/app/features/annotations/annotationsSrv.js @@ -1,9 +1,8 @@ define([ 'angular', 'lodash', - 'moment', './editorCtrl' -], function (angular, _, moment) { +], function (angular, _) { 'use strict'; var module = angular.module('grafana.services'); @@ -11,7 +10,6 @@ define([ module.service('annotationsSrv', function(datasourceSrv, $q, alertSrv, $rootScope, $sanitize) { var promiseCached; var list = []; - var timezone; var self = this; this.init = function() { @@ -33,7 +31,7 @@ define([ return promiseCached; } - timezone = dashboard.timezone; + self.dashboard = dashboard; var annotations = _.where(dashboard.annotations.list, {enable: true}); var promises = _.map(annotations, function(annotation) { @@ -54,31 +52,21 @@ define([ this.receiveAnnotationResults = function(results) { for (var i = 0; i < results.length; i++) { - addAnnotation(results[i]); + self.addAnnotation(results[i]); } }; - function errorHandler(err) { - console.log('Annotation error: ', err); - var message = err.message || "Annotation query failed"; - alertSrv.set('Annotations error', message,'error'); - } - - function addAnnotation(options) { + this.addAnnotation = function(options) { var title = $sanitize(options.title); - var tooltip = "" + title + "
"; + var time = '' + self.dashboard.formatDate(options.time) + ''; + + var tooltip = '
'+ title + ' ' + time + '
' ; + if (options.tags) { var tags = $sanitize(options.tags); tooltip += '' + (tags || '') + '
'; } - if (timezone === 'browser') { - tooltip += '' + moment(options.time).format('YYYY-MM-DD HH:mm:ss') + '
'; - } - else { - tooltip += '' + moment.utc(options.time).format('YYYY-MM-DD HH:mm:ss') + '
'; - } - if (options.text) { var text = $sanitize(options.text); tooltip += text.replace(/\n/g, '
'); @@ -95,6 +83,12 @@ define([ description: tooltip, score: 1 }); + }; + + function errorHandler(err) { + console.log('Annotation error: ', err); + var message = err.message || "Annotation query failed"; + alertSrv.set('Annotations error', message,'error'); } // Now init