HealthCheck: show enterprise commit (#75242)

This commit is contained in:
Ezequiel Victorero
2023-09-22 08:17:10 -03:00
committed by GitHub
parent 3529b7413d
commit 4cfc834c08
10 changed files with 102 additions and 30 deletions
+23
View File
@@ -36,6 +36,29 @@ func TestHealthAPI_Version(t *testing.T) {
require.JSONEq(t, expectedBody, rec.Body.String())
}
func TestHealthAPI_VersionEnterprise(t *testing.T) {
m, _ := setupHealthAPITestEnvironment(t, func(cfg *setting.Cfg) {
cfg.BuildVersion = "7.4.0"
cfg.EnterpriseBuildCommit = "22206ab1be"
cfg.BuildCommit = "59906ab1bf"
})
req := httptest.NewRequest(http.MethodGet, "/api/health", nil)
rec := httptest.NewRecorder()
m.ServeHTTP(rec, req)
require.Equal(t, 200, rec.Code)
expectedBody := `
{
"database": "ok",
"enterpriseCommit": "22206ab1be",
"version": "7.4.0",
"commit": "59906ab1bf"
}
`
require.JSONEq(t, expectedBody, rec.Body.String())
}
func TestHealthAPI_AnonymousHideVersion(t *testing.T) {
m, hs := setupHealthAPITestEnvironment(t)
hs.Cfg.AnonymousHideVersion = true
+3
View File
@@ -679,6 +679,9 @@ func (hs *HTTPServer) apiHealthHandler(ctx *web.Context) {
if !hs.Cfg.AnonymousHideVersion {
data.Set("version", hs.Cfg.BuildVersion)
data.Set("commit", hs.Cfg.BuildCommit)
if hs.Cfg.EnterpriseBuildCommit != "NA" && hs.Cfg.EnterpriseBuildCommit != "" {
data.Set("enterpriseCommit", hs.Cfg.EnterpriseBuildCommit)
}
}
if !hs.databaseHealthy(ctx.Req.Context()) {