SaveDashboard: Updated modal design/layout a bit (#22810)

(cherry picked from commit 46165a7f7b)
This commit is contained in:
Torkel Ödegaard
2020-03-19 12:27:02 +01:00
committed by Arve Knudsen
parent 6575c9cb6e
commit 4d235b978e
2 changed files with 23 additions and 20 deletions
@@ -10,6 +10,7 @@ import { Field } from './Field';
import { Button, LinkButton } from './Button'; import { Button, LinkButton } from './Button';
import { Switch } from './Switch'; import { Switch } from './Switch';
import { TextArea } from './TextArea/TextArea'; import { TextArea } from './TextArea/TextArea';
import { Checkbox } from './Checkbox';
const Forms = { const Forms = {
RadioButtonGroup, RadioButtonGroup,
@@ -26,6 +27,7 @@ const Forms = {
InputControl, InputControl,
AsyncSelect, AsyncSelect,
TextArea, TextArea,
Checkbox,
}; };
export { ButtonVariant } from './Button'; export { ButtonVariant } from './Button';
@@ -1,4 +1,5 @@
import React, { useMemo } from 'react'; import React, { useMemo } from 'react';
import { Forms, Button, HorizontalGroup } from '@grafana/ui'; import { Forms, Button, HorizontalGroup } from '@grafana/ui';
import { e2e } from '@grafana/e2e'; import { e2e } from '@grafana/e2e';
import { SaveDashboardFormProps } from '../types'; import { SaveDashboardFormProps } from '../types';
@@ -30,32 +31,32 @@ export const SaveDashboardForm: React.FC<SaveDashboardFormProps> = ({ dashboard,
> >
{({ register, errors }) => ( {({ register, errors }) => (
<> <>
<Forms.Field label="Changes description"> <div className="gf-form-group">
{hasTimeChanged && (
<Forms.Checkbox
label="Save current time range as dashboard default"
name="saveTimerange"
ref={register}
aria-label={e2e.pages.SaveDashboardModal.selectors.saveTimerange}
/>
)}
{hasVariableChanged && (
<Forms.Checkbox
label="Save current variable values as dashboard default"
name="saveVariables"
ref={register}
aria-label={e2e.pages.SaveDashboardModal.selectors.saveVariables}
/>
)}
{(hasVariableChanged || hasTimeChanged) && <div className="gf-form-group" />}
<Forms.TextArea <Forms.TextArea
name="message" name="message"
ref={register} ref={register}
placeholder="Add a note to describe your changes..." placeholder="Add a note to describe your changes..."
autoFocus autoFocus
/> />
</Forms.Field> </div>
{hasTimeChanged && (
<Forms.Field label="Save current time range" description="Dashboard time range has changed">
<Forms.Switch
name="saveTimerange"
ref={register}
aria-label={e2e.pages.SaveDashboardModal.selectors.saveTimerange}
/>
</Forms.Field>
)}
{hasVariableChanged && (
<Forms.Field label="Save current variables" description="Dashboard variables have changed">
<Forms.Switch
name="saveVariables"
ref={register}
aria-label={e2e.pages.SaveDashboardModal.selectors.saveVariables}
/>
</Forms.Field>
)}
<HorizontalGroup> <HorizontalGroup>
<Button type="submit" aria-label={e2e.pages.SaveDashboardModal.selectors.save}> <Button type="submit" aria-label={e2e.pages.SaveDashboardModal.selectors.save}>