From 4d9e5a8cebc1f410c554cf491dcacda1e17f3d3a Mon Sep 17 00:00:00 2001 From: Mariell Hoversholm Date: Thu, 14 Nov 2024 08:35:56 +0100 Subject: [PATCH] docs: comments --- pkg/apis/provisioning/v0alpha1/register.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pkg/apis/provisioning/v0alpha1/register.go b/pkg/apis/provisioning/v0alpha1/register.go index d9342dc85c6..c52a27a6517 100644 --- a/pkg/apis/provisioning/v0alpha1/register.go +++ b/pkg/apis/provisioning/v0alpha1/register.go @@ -22,12 +22,11 @@ var RepositoryResourceInfo = utils.NewResourceInfo(GROUP, VERSION, "repositories", "repository", "Repositories", func() runtime.Object { return &Repository{} }, // newObj func() runtime.Object { return &RepositoryList{} }, // newList - utils.TableColumns{ + utils.TableColumns{ // Returned by `kubectl get`. Doesn't affect disk storage. Definition: []metav1.TableColumnDefinition{ {Name: "Name", Type: "string", Format: "name"}, {Name: "Created At", Type: "date"}, - // TODO: Add more here when I figure out the model... - // I think this is just the table you get in `kubectl get`. It shouldn't deal with anything around storage. + // TODO: Add more here when we figure out the model... {Name: "Type", Type: "string"}, {Name: "Target", Type: "string"}, }, @@ -38,6 +37,7 @@ var RepositoryResourceInfo = utils.NewResourceInfo(GROUP, VERSION, } var typ, target string + // TODO: Can probably make this prettier. Function on Repository maybe? if !m.Spec.GitHub.IsEmpty() { typ = "github" // TODO: Enterprise GH??