public/grafana
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Graphite: Improve functions endpoint (#111902)

Browse Source 
Handle HTML response for functions endpoint

- If the endpoint starts with < return an error
- Update tests
- Catch error in FE and use default functions
This commit is contained in:
Andreas Christou
2025-10-01 20:04:34 +01:00
committed by GitHub
parent 0da9d49896
commit 4e2c3f19df
3 changed files with 39 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/tsdb/graphite/resource_handler_test.go
+23 -3
View File
@@ -735,21 +735,41 @@ func TestHandleFunctions(t *testing.T) {
responseBody: `{"error": "internal error"}`,
statusCode: 500,
expectError: true,
errorContains: "version request failed",
errorContains: "functions request failed",
},
{
name: "functions request not found",
responseBody: `{"error": "not found"}`,
statusCode: 404,
expectError: true,
errorContains: "version request failed",
errorContains: "functions request failed",
},
{
name: "network error",
responseBody: "",
statusCode: 0,
expectError: true,
errorContains: "version request failed",
errorContains: "functions request failed",
},
{
name: "html response",
responseBody: `<html>
<head>
<title>Graphite Browser</title>
</head>
<frameset rows="60,*" frameborder="1" border="1">
<frame src="/browser/header/" name="Header" id='header' scrolling="no" noresize="true" />
<frame src="/composer/?" name="content" id="composerFrame"/>
</frameset>
</html>
`,
statusCode: 200,
expectError: true,
errorContains: "invalid functions response received from Graphite",
},
}