From 4e3e58656eb8591a085015fdb70d4557aecf0c03 Mon Sep 17 00:00:00 2001 From: mikkancso Date: Wed, 22 Mar 2023 08:25:35 +0100 Subject: [PATCH] Connections: Turn on feature toggle by default (#64885) * turn on dataConnectionsConsole by default * change connection feature state to stable * generate feature toggle files * increase error threshold for pa11y --- .pa11yci-pr.conf.js | 4 +- .../feature-toggles/index.md | 108 +++++++++--------- pkg/services/featuremgmt/registry.go | 3 +- pkg/services/featuremgmt/toggles_gen.csv | 2 +- 4 files changed, 59 insertions(+), 58 deletions(-) diff --git a/.pa11yci-pr.conf.js b/.pa11yci-pr.conf.js index e912902c2e4..7b459c84ab5 100644 --- a/.pa11yci-pr.conf.js +++ b/.pa11yci-pr.conf.js @@ -107,7 +107,7 @@ var config = { url: '${HOST}/datasources', wait: 500, rootElement: '.main-view', - threshold: 1, + threshold: 3, }, { url: '${HOST}/org/users', @@ -125,7 +125,7 @@ var config = { url: '${HOST}/plugins', wait: 500, rootElement: '.main-view', - threshold: 1, + threshold: 3, }, { url: '${HOST}/org', diff --git a/docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md b/docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md index 881c1617099..cff8387c515 100644 --- a/docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md +++ b/docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md @@ -19,17 +19,18 @@ This page contains a list of available feature toggles. To learn how to turn on Some stable features are enabled by default. You can disable a stable feature by setting the feature flag to "false" in the configuration. -| Feature toggle name | Description | Enabled by default | -| ----------------------------------- | ------------------------------------------------------------------------------------ | ------------------ | -| `disableEnvelopeEncryption` | Disable envelope encryption (emergency only) | | -| `database_metrics` | Add Prometheus metrics for database tables | | -| `featureHighlights` | Highlight Grafana Enterprise features | | -| `cloudWatchDynamicLabels` | Use dynamic labels instead of alias patterns in CloudWatch datasource | Yes | -| `internationalization` | Enables internationalization | Yes | -| `cloudWatchCrossAccountQuerying` | Enables cross-account querying in CloudWatch datasources | Yes | -| `accessTokenExpirationCheck` | Enable OAuth access_token expiration check and token refresh using the refresh_token | | -| `disablePrometheusExemplarSampling` | Disable Prometheus examplar sampling | | -| `logsSampleInExplore` | Enables access to the logs sample feature in Explore | Yes | +| Feature toggle name | Description | Enabled by default | +| ----------------------------------- | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ------------------ | +| `disableEnvelopeEncryption` | Disable envelope encryption (emergency only) | | +| `database_metrics` | Add Prometheus metrics for database tables | | +| `featureHighlights` | Highlight Grafana Enterprise features | | +| `cloudWatchDynamicLabels` | Use dynamic labels instead of alias patterns in CloudWatch datasource | Yes | +| `dataConnectionsConsole` | Enables a new top-level page called Connections. This page is an experiment that provides a better experience when you install and configure data sources and other plugins. | Yes | +| `internationalization` | Enables internationalization | Yes | +| `cloudWatchCrossAccountQuerying` | Enables cross-account querying in CloudWatch datasources | Yes | +| `accessTokenExpirationCheck` | Enable OAuth access_token expiration check and token refresh using the refresh_token | | +| `disablePrometheusExemplarSampling` | Disable Prometheus examplar sampling | | +| `logsSampleInExplore` | Enables access to the logs sample feature in Explore | Yes | ## Beta feature toggles @@ -51,49 +52,48 @@ Some stable features are enabled by default. You can disable a stable feature by These features are early in their development lifecycle and so are not yet supported in Grafana Cloud. Alpha features might be changed or removed without prior notice. -| Feature toggle name | Description | -| ---------------------------------- | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | -| `alertingBigTransactions` | Use big transactions for alerting database writes | -| `dashboardPreviews` | Create and show thumbnails for dashboard search results | -| `live-pipeline` | Enable a generic live processing pipeline | -| `live-service-web-worker` | This will use a webworker thread to processes events rather than the main thread | -| `queryOverLive` | Use Grafana Live WebSocket to execute backend queries | -| `publicDashboards` | Enables public access to dashboards | -| `publicDashboardsEmailSharing` | Enables public dashboard sharing to be restricted to only allowed emails | -| `lokiLive` | Support WebSocket streaming for loki (early prototype) | -| `lokiDataframeApi` | Use experimental loki api for WebSocket streaming (early prototype) | -| `storage` | Configurable storage for dashboards, datasources, and resources | -| `exploreMixedDatasource` | Enable mixed datasource in Explore | -| `newTraceView` | Shows the new trace view design | -| `correlations` | Correlations page | -| `datasourceQueryMultiStatus` | Introduce HTTP 207 Multi Status for api/ds/query | -| `traceToMetrics` | Enable trace to metrics links | -| `prometheusWideSeries` | Enable wide series responses in the Prometheus datasource | -| `canvasPanelNesting` | Allow elements nesting | -| `scenes` | Experimental framework to build interactive dashboards | -| `disableSecretsCompatibility` | Disable duplicated secret storage in legacy tables | -| `logRequestsInstrumentedAsUnknown` | Logs the path for requests that are instrumented as unknown | -| `dataConnectionsConsole` | Enables a new top-level page called Connections. This page is an experiment that provides a better experience when you install and configure data sources and other plugins. | -| `redshiftAsyncQueryDataSupport` | Enable async query data support for Redshift | -| `athenaAsyncQueryDataSupport` | Enable async query data support for Athena | -| `newPanelChromeUI` | Show updated look and feel of grafana-ui PanelChrome: panel header, icons, and menu | -| `showDashboardValidationWarnings` | Show warnings when dashboards do not validate against the schema | -| `mysqlAnsiQuotes` | Use double quotes to escape keyword in a MySQL query | -| `elasticsearchBackendMigration` | Use Elasticsearch as backend data source | -| `datasourceOnboarding` | Enable data source onboarding page | -| `secureSocksDatasourceProxy` | Enable secure socks tunneling for supported core datasources | -| `authnService` | Use new auth service to perform authentication | -| `alertingBacktesting` | Rule backtesting API for alerting | -| `editPanelCSVDragAndDrop` | Enables drag and drop for CSV and Excel files | -| `logsContextDatasourceUi` | Allow datasource to provide custom UI for context view | -| `lokiQuerySplitting` | Split large interval queries into subqueries with smaller time intervals | -| `lokiQuerySplittingConfig` | Give users the option to configure split durations for Loki queries | -| `individualCookiePreferences` | Support overriding cookie preferences per user | -| `drawerDataSourcePicker` | Changes the user experience for data source selection to a drawer. | -| `traceqlSearch` | Enables the 'TraceQL Search' tab for the Tempo datasource which provides a UI to generate TraceQL queries | -| `prometheusMetricEncyclopedia` | Replaces the Prometheus query builder metric select option with a paginated and filterable component | -| `timeSeriesTable` | Enable time series table transformer & sparkline cell type | -| `influxdbBackendMigration` | Query InfluxDB InfluxQL without the proxy | +| Feature toggle name | Description | +| ---------------------------------- | --------------------------------------------------------------------------------------------------------- | +| `alertingBigTransactions` | Use big transactions for alerting database writes | +| `dashboardPreviews` | Create and show thumbnails for dashboard search results | +| `live-pipeline` | Enable a generic live processing pipeline | +| `live-service-web-worker` | This will use a webworker thread to processes events rather than the main thread | +| `queryOverLive` | Use Grafana Live WebSocket to execute backend queries | +| `publicDashboards` | Enables public access to dashboards | +| `publicDashboardsEmailSharing` | Enables public dashboard sharing to be restricted to only allowed emails | +| `lokiLive` | Support WebSocket streaming for loki (early prototype) | +| `lokiDataframeApi` | Use experimental loki api for WebSocket streaming (early prototype) | +| `storage` | Configurable storage for dashboards, datasources, and resources | +| `exploreMixedDatasource` | Enable mixed datasource in Explore | +| `newTraceView` | Shows the new trace view design | +| `correlations` | Correlations page | +| `datasourceQueryMultiStatus` | Introduce HTTP 207 Multi Status for api/ds/query | +| `traceToMetrics` | Enable trace to metrics links | +| `prometheusWideSeries` | Enable wide series responses in the Prometheus datasource | +| `canvasPanelNesting` | Allow elements nesting | +| `scenes` | Experimental framework to build interactive dashboards | +| `disableSecretsCompatibility` | Disable duplicated secret storage in legacy tables | +| `logRequestsInstrumentedAsUnknown` | Logs the path for requests that are instrumented as unknown | +| `redshiftAsyncQueryDataSupport` | Enable async query data support for Redshift | +| `athenaAsyncQueryDataSupport` | Enable async query data support for Athena | +| `newPanelChromeUI` | Show updated look and feel of grafana-ui PanelChrome: panel header, icons, and menu | +| `showDashboardValidationWarnings` | Show warnings when dashboards do not validate against the schema | +| `mysqlAnsiQuotes` | Use double quotes to escape keyword in a MySQL query | +| `elasticsearchBackendMigration` | Use Elasticsearch as backend data source | +| `datasourceOnboarding` | Enable data source onboarding page | +| `secureSocksDatasourceProxy` | Enable secure socks tunneling for supported core datasources | +| `authnService` | Use new auth service to perform authentication | +| `alertingBacktesting` | Rule backtesting API for alerting | +| `editPanelCSVDragAndDrop` | Enables drag and drop for CSV and Excel files | +| `logsContextDatasourceUi` | Allow datasource to provide custom UI for context view | +| `lokiQuerySplitting` | Split large interval queries into subqueries with smaller time intervals | +| `lokiQuerySplittingConfig` | Give users the option to configure split durations for Loki queries | +| `individualCookiePreferences` | Support overriding cookie preferences per user | +| `drawerDataSourcePicker` | Changes the user experience for data source selection to a drawer. | +| `traceqlSearch` | Enables the 'TraceQL Search' tab for the Tempo datasource which provides a UI to generate TraceQL queries | +| `prometheusMetricEncyclopedia` | Replaces the Prometheus query builder metric select option with a paginated and filterable component | +| `timeSeriesTable` | Enable time series table transformer & sparkline cell type | +| `influxdbBackendMigration` | Query InfluxDB InfluxQL without the proxy | ## Development feature toggles diff --git a/pkg/services/featuremgmt/registry.go b/pkg/services/featuremgmt/registry.go index 5d382a6004a..8d0b2815b98 100644 --- a/pkg/services/featuremgmt/registry.go +++ b/pkg/services/featuremgmt/registry.go @@ -217,7 +217,8 @@ var ( { Name: "dataConnectionsConsole", Description: "Enables a new top-level page called Connections. This page is an experiment that provides a better experience when you install and configure data sources and other plugins.", - State: FeatureStateAlpha, + State: FeatureStateStable, + Expression: "true", // turned on by default Owner: grafanaPluginsPlatformSquad, }, { diff --git a/pkg/services/featuremgmt/toggles_gen.csv b/pkg/services/featuremgmt/toggles_gen.csv index 53f71e13a04..837acc653f4 100644 --- a/pkg/services/featuremgmt/toggles_gen.csv +++ b/pkg/services/featuremgmt/toggles_gen.csv @@ -31,7 +31,7 @@ canvasPanelNesting,alpha,@grafana/dataviz-squad,false,false,false,true scenes,alpha,@grafana/dashboards-squad,false,false,false,true disableSecretsCompatibility,alpha,@grafana/hosted-grafana-team,false,false,true,false logRequestsInstrumentedAsUnknown,alpha,@grafana/hosted-grafana-team,false,false,false,false -dataConnectionsConsole,alpha,@grafana/plugins-platform-backend,false,false,false,false +dataConnectionsConsole,stable,@grafana/plugins-platform-backend,false,false,false,false internationalization,stable,@grafana/user-essentials,false,false,false,false topnav,beta,@grafana/user-essentials,false,false,false,false grpcServer,alpha,@grafana/grafana-app-platform-squad,true,false,false,false