public/grafana
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ChangePassword: improved keyboard navigation (#29567)

Browse Source 
* ChangePassword: improved keyboard navigation

* updated skip button with appropriate tag

* applied box shadow to skip button
This commit is contained in:
Uchechukwu Obasi
2020-12-10 09:41:44 +01:00
committed by GitHub
parent 955c96ffd8
commit 4ea2c7d2b1
2 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/grafana-ui/src/components/Button/Button.tsx
-1
View File
@@ -51,7 +51,6 @@ const getPropertiesForVariant = (theme: GrafanaTheme, variant: ButtonVariant) =>
variantStyles: css` variantStyles: css`
&:focus { &:focus {
outline: none; outline: none;
box-shadow: none;
} }
`, `,
}; };
public/app/core/components/ForgottenPassword/ChangePassword.tsx
+3 -3
View File
@@ -1,5 +1,5 @@
import React, { FC, SyntheticEvent } from 'react'; import React, { FC, SyntheticEvent } from 'react';
import { Tooltip, Form, Field, Input, VerticalGroup, Button, LinkButton } from '@grafana/ui'; import { Tooltip, Form, Field, Input, VerticalGroup, Button } from '@grafana/ui';
import { selectors } from '@grafana/e2e-selectors'; import { selectors } from '@grafana/e2e-selectors';
import { submitButton } from '../Login/LoginForm'; import { submitButton } from '../Login/LoginForm';
interface Props { interface Props {
@@ -50,9 +50,9 @@ export const ChangePassword: FC<Props> = ({ onSubmit, onSkip }) => {
content="If you skip you will be prompted to change password next time you log in." content="If you skip you will be prompted to change password next time you log in."
placement="bottom" placement="bottom"
> >
<LinkButton variant="link" onClick={onSkip} aria-label={selectors.pages.Login.skip}> <Button variant="link" onClick={onSkip} type="button" aria-label={selectors.pages.Login.skip}>
Skip Skip
</LinkButton> </Button>
</Tooltip> </Tooltip>
)} )}
</VerticalGroup> </VerticalGroup>