From 4f5b80095edebc95ba99c53e2cb00e32bf464873 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Piotr=20Jamr=C3=B3z?= <pm.jamroz@gmail.com>
Date: Fri, 14 Apr 2023 14:25:07 +0200
Subject: [PATCH] Dashboards: Fix broken internal data links (#66567)

* In dashboards splitOpenFn is not passed, instead "href" link is used. When we added tracking we changed the behaviour so onClickFn is always passed when generating the model. To bring back the previous behaviour we skip the onClickFn if the split function is not provided.

* Fix test and add a task to re-check the logic
---
 public/app/features/explore/utils/links.test.ts | 6 +-----
 public/app/features/explore/utils/links.ts      | 4 +++-
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/public/app/features/explore/utils/links.test.ts b/public/app/features/explore/utils/links.test.ts
index ef459db08b5..86f84abd7d1 100644
--- a/public/app/features/explore/utils/links.test.ts
+++ b/public/app/features/explore/utils/links.test.ts
@@ -315,11 +315,7 @@ describe('explore links utils', () => {
         links[0][0].onClick({});
       }
 
-      expect(reportInteraction).toBeCalledWith('grafana_data_link_clicked', {
-        app: CoreApp.Explore,
-        internal: true,
-        origin: DataLinkConfigOrigin.Correlations,
-      });
+      expect(reportInteraction).not.toBeCalled();
 
       expect(links[1]).toHaveLength(1);
       expect(links[1][0].href).toBe(
diff --git a/public/app/features/explore/utils/links.ts b/public/app/features/explore/utils/links.ts
index 818ff1566ca..881fb025b12 100644
--- a/public/app/features/explore/utils/links.ts
+++ b/public/app/features/explore/utils/links.ts
@@ -195,7 +195,9 @@ export const getFieldLinksForExplore = (options: {
             scopedVars: allVars,
             range,
             field,
-            onClickFn: (options) => splitFnWithTracking(options),
+            // Don't track internal links without split view as they are used only in Dashboards
+            // TODO: It should be revisited in #66570
+            onClickFn: options.splitOpenFn ? (options) => splitFnWithTracking(options) : undefined,
             replaceVariables: getTemplateSrv().replace.bind(getTemplateSrv()),
           });
           return { ...internalLink, variables: variables };