Alerting: take datasources as external alertmanagers into consideration (#52534)

2022-07-20 16:50:49 +02:00
parent 5c4aa4a7ac
commit 50ae42130b
12 changed files with 332 additions and 24 deletions
@@ -0,0 +1,117 @@
+package api
+
+import (
+	"encoding/json"
+	"net/http"
+	"testing"
+
+	"github.com/grafana/grafana/pkg/components/simplejson"
+	"github.com/grafana/grafana/pkg/models"
+	"github.com/grafana/grafana/pkg/services/datasources"
+	fakeDatasources "github.com/grafana/grafana/pkg/services/datasources/fakes"
+	"github.com/grafana/grafana/pkg/services/ngalert/api/tooling/definitions"
+	"github.com/grafana/grafana/pkg/services/ngalert/store"
+	"github.com/stretchr/testify/require"
+)
+
+func TestExternalAlertmanagerChoice(t *testing.T) {
+	tests := []struct {
+		name               string
+		alertmanagerChoice definitions.AlertmanagersChoice
+		alertmanagers      []string
+		datasources        []*datasources.DataSource
+		statusCode         int
+		message            string
+	}{
+		{
+			name:               "setting the choice to external by passing a plain url should succeed",
+			alertmanagerChoice: definitions.ExternalAlertmanagers,
+			alertmanagers:      []string{"http://localhost:9000"},
+			datasources:        []*datasources.DataSource{},
+			statusCode:         http.StatusCreated,
+			message:            "admin configuration updated",
+		},
+		{
+			name:               "setting the choice to external by having a enabled external am datasource should succeed",
+			alertmanagerChoice: definitions.ExternalAlertmanagers,
+			alertmanagers:      []string{},
+			datasources: []*datasources.DataSource{
+				{
+					OrgId: 1,
+					Type:  datasources.DS_ALERTMANAGER,
+					Url:   "http://localhost:9000",
+					JsonData: simplejson.NewFromAny(map[string]interface{}{
+						definitions.HandleGrafanaManagedAlerts: true,
+					}),
+				},
+			},
+			statusCode: http.StatusCreated,
+			message:    "admin configuration updated",
+		},
+		{
+			name:               "setting the choice to external by having a disabled external am datasource should fail",
+			alertmanagerChoice: definitions.ExternalAlertmanagers,
+			alertmanagers:      []string{},
+			datasources: []*datasources.DataSource{
+				{
+					OrgId:    1,
+					Type:     datasources.DS_ALERTMANAGER,
+					Url:      "http://localhost:9000",
+					JsonData: simplejson.NewFromAny(map[string]interface{}{}),
+				},
+			},
+			statusCode: http.StatusBadRequest,
+			message:    "At least one Alertmanager must be provided or configured as a datasource that handles alerts to choose this option",
+		},
+		{
+			name:               "setting the choice to external and having no am configured should fail",
+			alertmanagerChoice: definitions.ExternalAlertmanagers,
+			alertmanagers:      []string{},
+			datasources:        []*datasources.DataSource{},
+			statusCode:         http.StatusBadRequest,
+			message:            "At least one Alertmanager must be provided or configured as a datasource that handles alerts to choose this option",
+		},
+		{
+			name:               "setting the choice to all and having no external am configured should succeed",
+			alertmanagerChoice: definitions.AllAlertmanagers,
+			alertmanagers:      []string{},
+			datasources:        []*datasources.DataSource{},
+			statusCode:         http.StatusCreated,
+			message:            "admin configuration updated",
+		},
+		{
+			name:               "setting the choice to internal should always succeed",
+			alertmanagerChoice: definitions.InternalAlertmanager,
+			alertmanagers:      []string{},
+			datasources:        []*datasources.DataSource{},
+			statusCode:         http.StatusCreated,
+			message:            "admin configuration updated",
+		},
+	}
+	ctx := createRequestCtxInOrg(1)
+	ctx.OrgRole = models.ROLE_ADMIN
+	for _, test := range tests {
+		t.Run(test.name, func(t *testing.T) {
+			sut := createAPIAdminSut(t, test.datasources)
+			resp := sut.RoutePostNGalertConfig(ctx, definitions.PostableNGalertConfig{
+				Alertmanagers:       test.alertmanagers,
+				AlertmanagersChoice: test.alertmanagerChoice,
+			})
+			var res map[string]interface{}
+			err := json.Unmarshal(resp.Body(), &res)
+			require.NoError(t, err)
+			require.Equal(t, test.message, res["message"])
+			require.Equal(t, test.statusCode, resp.Status())
+		})
+	}
+}
+
+func createAPIAdminSut(t *testing.T,
+	datasources []*datasources.DataSource) ConfigSrv {
+	return ConfigSrv{
+		datasourceService: &fakeDatasources.FakeDataSourceService{
+			DataSources: datasources,
+		},
+		store: store.NewFakeAdminConfigStore(t),
+	}
+}